feat(review): add linked-issue satisfaction advisory + unified-comment section - #3833
Merged
Merged
Conversation
…t section Adds the pure, AI-backed assessment core (#2172): given the already-fetched linked-issue text plus the PR title/body/diff, compose a bounded prompt and parse a model's response into a public-safe {status, rationale, confidence} result. Fail-safe throughout -- no issue text, unparseable output, or a below-floor "unaddressed" call all yield no finding, so the model can never manufacture an unearned "you didn't fix this". Prompt composition and response parsing only; no gate wiring, no AI-call orchestration, no disposition change. Also renders a resolved result as an additive, collapsed "Linked issue satisfaction" section in the unified review comment (#2174), reusing the existing collapsible + angle-escape helpers. Absent result omits the section entirely; review.comment_verbosity: quiet drops it like every other decorative collapsible. Presentation only -- never changes status or the gate verdict.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3833 +/- ##
=======================================
Coverage 93.41% 93.42%
=======================================
Files 326 327 +1
Lines 32855 32897 +42
Branches 12035 12051 +16
=======================================
+ Hits 30691 30733 +42
Misses 1530 1530
Partials 634 634
🚀 New features to boost your workflow:
|
Contributor
|
Important 🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪 🔍 Gittensory is reviewing…AI analysis is in progress. This comment will update when the review is complete. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing |
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{status, rationale, confidence}result. Prompt composition and response parsing only -- no gate wiring, no AI-call orchestration, no disposition change.review.comment_verbosity: quietdrops it like every other decorative collapsible.unaddressedcall all yield no finding -- the model can never manufacture an unearned "you didn't fix this." Presentation is additive only and never changesstatusor the gate verdict.Closes #2172, Closes #2174 -- both deliverables fully implemented in this PR. Advances #1961 (not closed -- the AI-call orchestration and any future
gate.linkedIssueSatisfactiondisposition wiring remain separate, maintainer-only slices).Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally -- 100% branch coverage on both changed files (src/services/linked-issue-satisfaction.ts,src/review/unified-comment.ts's new lines)npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateSafety
UI Evidencesection below. (N/A -- no visible frontend/UI change; this renders inside a GitHub PR comment, not the web app.)Notes
src/services/linked-issue-satisfaction.tsmirrorssrc/services/ai-slop.ts's pure-helper shape (prompt builder + response parser + finding builder, no I/O) -- the actual AI-call orchestration (budget, provider selection, usage accounting) is intentionally out of scope for feat(review): pure linked-issue satisfaction assessment builder (advisory finding) #2172 per its own deliverables checklist.LINKED_ISSUE_SATISFACTION_CONFIDENCE_FLOOR = 0.5) only gates theunaddressedverdict, matching the issue's fail-safe requirement ("low confidence never emits 'unaddressed'");addressed/partialare unaffected since a false-positive "looks addressed" is a lower-stakes error.