fix(signals): single-source isCodeFile via isSourcePath and add .kts#3889
Conversation
Delegate path-matchers and engine isCodeFile to isSourcePath so the JVM/.NET/Swift/Groovy/Kotlin-script source set stays symmetric with isTestPath and cannot drift. Adds .kts source classification so Gradle Kotlin-script changes are no longer invisible to missing-tests gates. Co-authored-by: Cursor <cursoragent@cursor.com>
Add a buildPreflightResult regression so engine.ts inheriting path-matchers isCodeFile (and its .g.dart/.freezed.dart exclusion) stays covered at the signals layer. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review result - approve/merge recommendedReview updated: 2026-07-07 05:51:52 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 5 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
|
Follow-up PR #3921 (CI green, Gittensory approve) was auto-closed because it linked maintainer-reserved #2235. The MCP .kts classifier parity fix is ready on \RealDiligent:fix/mcp-iscodefile-kts-parity. Could a maintainer please open a contributor-eligible upstream tracking issue for this follow-up so we can re-open with \Closes #…? |
Add .kts to the MCP local-branch and score-preview classifiers so Gradle Kotlin-script source counts as code in local score previews, matching merged JSONbored#3889 server isSourcePath behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Add .kts to the MCP local-branch and score-preview classifiers so Gradle Kotlin-script source counts as code in local score previews, matching merged JSONbored#3889 server isSourcePath behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Add .kts to the MCP local-branch and score-preview classifiers so Gradle Kotlin-script source counts as code in local score previews, matching merged JSONbored#3889 server isSourcePath behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Add .kts to the MCP local-branch and score-preview classifiers so Gradle Kotlin-script source counts as code in local score previews, matching merged JSONbored#3889 server isSourcePath behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
Hardens
src/signals/test-evidence.tsahead of the gittensory-engine extraction tracked in #2277 by introducing canonicalisSourcePath(symmetric withisTestPath) and delegatingpath-matchers.ts/engine.tsisCodeFileto it. Also closes the.ktsgap where Gradle Kotlin-script source escaped missing-tests gate signals whileisTestPathalready recognized.ktstest files.Closes #2277
Scope
CONTRIBUTING.md; no UI/API/schema/migration changes.Validation
npm test -- test/unit/test-evidence.test.ts test/unit/local-branch-file-classifiers.test.ts test/unit/path-matchers.test.ts test/unit/signals.test.tsvalidate-code+validategreen on this PRSafety
.ktssource and consolidates duplicate matchers.