fix(github): preserve colliding check-run failures#3968
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - fixes requiredReview updated: 2026-07-07 08:19:40 UTC
🛑 Suggested Action - Manual Review
Review summary Nits — 5 non-blocking
Why this is blocked
CI checks failing
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3968 +/- ##
=======================================
Coverage 93.70% 93.70%
=======================================
Files 373 373
Lines 35076 35087 +11
Branches 12863 12868 +5
=======================================
+ Hits 32868 32879 +11
Misses 1584 1584
Partials 624 624
🚀 New features to boost your workflow:
|
81046b5 to
17143ed
Compare
Motivation
passed.Description
namealone and leave runs without a suite id undeduped so observed failures can't be hidden.check_suite.databaseIdto the GraphQL rollup mapping and includecheck_suite/idon REST fixtures so both REST and GraphQL paths share the same safe identity boundary.dedupeLatestCheckRunsByNamewithdedupeLatestCheckRunsByIdentityand addcheckRunDedupeKeyto compute the identity, tiebreaking bystarted_at(or array order when missing).Testing
npx vitest run test/unit/graphql-status-rollup.test.ts(all tests passed) andnpx vitest run test/unit/backfill.test.ts -t "duplicate-named check-runs"(tests passed with many unrelated cases skipped).npm run typecheckwhich succeeded andgit diff --checkwhich reported no issues.npm run test:coveragewas attempted but the targeted run did not finish here and an earlier attempt used an unsupported Vitest option;npm audit --audit-level=moderatereturned a403 Forbiddenfrom the registry in this environment.Codex Task