Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/review/unified-comment-bridge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -666,6 +666,7 @@ export function buildUnifiedCommentBody(args: UnifiedCommentBridgeArgs): string
...(args.merged !== undefined ? { merged: args.merged } : {}),
...(args.reviewEffort !== undefined ? { reviewEffort: args.reviewEffort } : {}),
...(args.maxFindingsCaps !== undefined ? { maxFindingsCaps: args.maxFindingsCaps } : {}),
...(args.findingCategories !== undefined ? { inlineFindings: args.findingCategories } : {}),
});
// The gate already produced 0/1 reviewer notes from a synthesis of the model pair; reflect the caller's
// actual reviewer count (for the chip + the "N reviewers, synthesized" evidence) without re-deriving it.
Expand Down
2 changes: 2 additions & 0 deletions src/review/unified-comment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,7 @@ export function buildUnifiedReviewInput(opts: {
reviewEffort?: { band: 1 | 2 | 3 | 4 | 5; minutes: number };
maxFindingsCaps?: { blockers: number | null; nits: number | null };
linkedIssueSatisfaction?: { status: "addressed" | "partial" | "unaddressed"; rationale: string };
inlineFindings?: ReadonlyArray<{ category?: UnifiedFindingCategory | undefined }>;
}): UnifiedReviewInput {
const ex = extractReviewSummary(opts.reviews);
const changedFiles = typeof opts.changedFiles === "number" ? opts.changedFiles : opts.changedFiles.length;
Expand All @@ -720,6 +721,7 @@ export function buildUnifiedReviewInput(opts: {
...(opts.reviewEffort !== undefined ? { reviewEffort: opts.reviewEffort } : {}),
...(opts.maxFindingsCaps !== undefined ? { maxFindingsCaps: opts.maxFindingsCaps } : {}),
...(opts.linkedIssueSatisfaction !== undefined ? { linkedIssueSatisfaction: opts.linkedIssueSatisfaction } : {}),
...(opts.inlineFindings !== undefined ? { inlineFindings: opts.inlineFindings } : {}),
};
}

Expand Down
9 changes: 6 additions & 3 deletions test/unit/finding-category-collapsible.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,19 +86,22 @@ describe("buildUnifiedCommentBody findingCategories wiring (#1958)", () => {
footerMarkdown: footer,
};

it("appends the Finding categories section when findingCategories is present + non-empty", () => {
it("appends both category summaries when findingCategories is present + non-empty", () => {
const body = buildUnifiedCommentBody({ ...base, findingCategories: findings });
expect(body).toContain("**Findings by category:** 1 security");
expect(body).toContain("Finding categories");
expect(body).toContain("| Security | 1 |");
});

it("does NOT add a Finding categories section when findingCategories is absent (flag-OFF parity)", () => {
it("does NOT add category summaries when findingCategories is absent (flag-OFF parity)", () => {
const body = buildUnifiedCommentBody(base);
expect(body).not.toContain("Findings by category");
expect(body).not.toContain("Finding categories");
});

it("does NOT add a Finding categories section when findingCategories is empty", () => {
it("does NOT add category summaries when findingCategories is empty", () => {
const body = buildUnifiedCommentBody({ ...base, findingCategories: [] });
expect(body).not.toContain("Findings by category");
expect(body).not.toContain("Finding categories");
});

Expand Down