Skip to content

fix(db): dedupe focus manifest snapshots#4015

Merged
JSONbored merged 1 commit into
mainfrom
codex/fix-focus-manifest-snapshot-deduplication
Jul 7, 2026
Merged

fix(db): dedupe focus manifest snapshots#4015
JSONbored merged 1 commit into
mainfrom
codex/fix-focus-manifest-snapshot-deduplication

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • Prevent storage exhaustion by restoring latest-only deduplication for focus-manifest cache snapshots so repeated private/public focus-manifest writes do not accumulate as superseded rows.

Description

  • Add repo-focus-manifest and repo-public-focus-manifest to the LATEST_ONLY_SIGNAL_SNAPSHOT_TYPES allowlist in src/db/retention.ts so they are included in the per-type latest-only dedupe pass.
  • Add a regression unit test in test/unit/retention.test.ts that seeds duplicate private and public focus-manifest snapshots, runs dedupeSignalSnapshots, and asserts only the latest snapshot for each signal type remains.

Testing

  • Ran npx vitest run test/unit/retention.test.ts, and the modified retention unit tests passed.
  • Ran npm run typecheck, which succeeded with no TypeScript errors.
  • Attempted npm run test:coverage -- test/unit/retention.test.ts, where the unit tests passed but coverage remapping failed with TypeError: jsTokens is not a function (coverage tool error unrelated to the logic change).
  • Attempted the full local gate with npm run test:ci, which did not complete in this environment due to a longer-running coverage/worker test run that was terminated; prerequisite checks (typecheck) had passed earlier.

Codex Task

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.58%. Comparing base (3a74800) to head (998f9dd).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4015   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files         381      381           
  Lines       35483    35483           
  Branches    13014    13014           
=======================================
  Hits        33206    33206           
  Misses       1617     1617           
  Partials      660      660           
Files with missing lines Coverage Δ
src/db/retention.ts 96.49% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 7, 2026
@loopover-orb

loopover-orb Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-07 12:20:49 UTC

2 files · 2 blockers · readiness 93/100 · CI green · clean

⏸️ Suggested Action - Manual Review

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

Concerns raised — review before merging

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.
Signal Result Evidence
Code review ❌ 2 blockers No AI review summary
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 51 registered-repo PR(s), 43 merged, 570 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 51 PR(s), 570 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, TypeScript, JavaScript, Ruby, Go, Kotlin, MDX, Shell
  • Official Gittensor activity: 51 PR(s), 570 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Explain no-issue PR.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@JSONbored
JSONbored force-pushed the codex/fix-focus-manifest-snapshot-deduplication branch from e6a9786 to 998f9dd Compare July 7, 2026 12:13
@JSONbored
JSONbored merged commit 49ac8d5 into main Jul 7, 2026
10 checks passed
@JSONbored
JSONbored deleted the codex/fix-focus-manifest-snapshot-deduplication branch July 7, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Development

Successfully merging this pull request may close these issues.

1 participant