fix(db): dedupe focus manifest snapshots#4015
Merged
Merged
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4015 +/- ##
=======================================
Coverage 93.58% 93.58%
=======================================
Files 381 381
Lines 35483 35483
Branches 13014 13014
=======================================
Hits 33206 33206
Misses 1617 1617
Partials 660 660
🚀 New features to boost your workflow:
|
Contributor
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-07 12:20:49 UTC
⏸️ Suggested Action - Manual Review
Concerns raised — review before merging
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
JSONbored
force-pushed
the
codex/fix-focus-manifest-snapshot-deduplication
branch
from
July 7, 2026 11:25
19734da to
e6a9786
Compare
JSONbored
force-pushed
the
codex/fix-focus-manifest-snapshot-deduplication
branch
from
July 7, 2026 12:13
e6a9786 to
998f9dd
Compare
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
repo-focus-manifestandrepo-public-focus-manifestto theLATEST_ONLY_SIGNAL_SNAPSHOT_TYPESallowlist insrc/db/retention.tsso they are included in the per-type latest-only dedupe pass.test/unit/retention.test.tsthat seeds duplicate private and public focus-manifest snapshots, runsdedupeSignalSnapshots, and asserts only the latest snapshot for each signal type remains.Testing
npx vitest run test/unit/retention.test.ts, and the modified retention unit tests passed.npm run typecheck, which succeeded with no TypeScript errors.npm run test:coverage -- test/unit/retention.test.ts, where the unit tests passed but coverage remapping failed withTypeError: jsTokens is not a function(coverage tool error unrelated to the logic change).npm run test:ci, which did not complete in this environment due to a longer-running coverage/worker test run that was terminated; prerequisite checks (typecheck) had passed earlier.Codex Task