fix(review): skip actuation lock for first draft conversion to prevent double-counting on retry by JSONbored · Pull Request #4016 · JSONbored/loopover

JSONbored · 2026-07-07T10:20:20Z

Motivation

Prevent a non-idempotent path where the first converted_to_draft delivery increments the per-PR counter, then fails acquiring the actuation lock and is retried, causing the same delivery to be counted twice and incorrectly treated as a repeated conversion.

Description

Return early from maybeCloseRepeatedDraftCycling when draftConversionCount < 2 so the handler does not claim the per-PR actuation lock for a first-time conversion and therefore cannot be double-counted on retry.
Preserve the existing enforcement and retry semantics for genuine repeated conversions (count >= 2) so they still claim the lock and may retry on contention.
Updated tests in test/unit/queue.test.ts to add a regression case proving the first conversion returns before claiming the repeated-cycle lock and to keep coverage for the lock-contention retry on later conversions.
Files changed: src/queue/processors.ts, test/unit/queue.test.ts.

Testing

Ran the focused unit suite for the affected scenarios with npx vitest run test/unit/queue.test.ts -t "repeated ready<->draft cycling", and the targeted tests passed.
Ran early parts of the full gate (git diff --check, lint/migration/schema checks and started npm run test:coverage) which progressed, but the full npm run test:ci coverage run was long-running and was interrupted before completion during this session.
npm audit --audit-level=moderate was attempted but the registry audit endpoint returned 403 Forbidden, so the dependency-audit step could not complete here.

Codex Task

superagent-security · 2026-07-07T10:21:30Z

Superagent didn't find any vulnerabilities or security issues in this PR.

loopover-orb · 2026-07-07T10:27:44Z

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review result - fixes required

_{Review updated: 2026-07-07 11:35:47 UTC}

1 file · 2 blockers · readiness 93/100 · CI failing · unknown

🛑 Suggested Action - Manual Review

No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

Why this is blocked

No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

CI checks failing

validate
validate-code

Signal	Result	Evidence
Code review	❌ 2 blockers	No AI review summary
Linked issue	⚠️ Missing	No linked issue or no-issue rationale found.
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (no linked issue context).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 51 registered-repo PR(s), 43 merged, 570 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 51 PR(s), 570 issue(s).
Gate result	❌ Blocking	Repo-configured hard blocker found.

Review context

Author: JSONbored
Role context: owner (maintainer lane)
Public audience mode: oss maintainer
Lane context: Repository is configured for direct PR review.
Public profile languages: Python, TypeScript, JavaScript, Ruby, Go, Kotlin, MDX, Shell
Official Gittensor activity: 51 PR(s), 570 issue(s).
PR-specific overlap: none found.

Contributor next steps

Treat this as maintainer-lane context rather than normal contributor-lane activity.
Explain no-issue PR.
Link the issue being solved, or explicitly explain why this is a no-issue PR.

Signal definitions

Related work = same linked issue, overlapping active PRs, or title/path similarity.
Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

Re-run Gittensory review

codecov · 2026-07-07T11:35:33Z

❌ 51 Tests Failed:

Tests completed	Failed	Passed	Skipped
10454	51	10403	7

View the top 3 failed test(s) by shortest run time

test/unit/mcp-server-telemetry.test.ts > MCP server telemetry > falls back when Hono does not expose an execution context

Stack Traces | 0.0136s run time

Error: Failed to resolve entry for package "@jsonbored/gittensory-engine". The package may have incorrect main/module/exports specified in its package.json.
 ❯ .../gittensory-miner/lib/opportunity-fanout.js:2:1
 ❯ src/mcp/find-opportunities.ts:11:1

test/unit/mcp-server-telemetry.test.ts > MCP server telemetry > records session-scoped MCP request errors without a tool name

Stack Traces | 0.0227s run time

Error: Failed to resolve entry for package "@jsonbored/gittensory-engine". The package may have incorrect main/module/exports specified in its package.json.
 ❯ .../gittensory-miner/lib/opportunity-fanout.js:2:1
 ❯ src/mcp/find-opportunities.ts:11:1

test/unit/mcp-server-telemetry.test.ts > MCP server telemetry > records sanitized error telemetry when the MCP transport handler throws

Stack Traces | 0.231s run time

Error: Failed to resolve entry for package "@jsonbored/gittensory-engine". The package may have incorrect main/module/exports specified in its package.json.
 ❯ .../gittensory-miner/lib/opportunity-fanout.js:2:1
 ❯ src/mcp/find-opportunities.ts:11:1

View the full list of 48 ❄️ flaky test(s)

test/integration/api.test.ts > test/integration/api.test.ts