fix(selfhost): catch startup orb relay drain failures#4018
Merged
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Contributor
|
Important 🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪 🔍 Gittensory is reviewing…AI analysis is in progress. This comment will update when the review is complete. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing |
JSONbored
force-pushed
the
codex/propose-fix-for-self-host-startup-drain
branch
from
July 7, 2026 11:30
f935c63 to
2e5ea8d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4018 +/- ##
=======================================
Coverage 93.58% 93.58%
=======================================
Files 381 381
Lines 35483 35483
Branches 13014 13014
=======================================
Hits 33206 33206
Misses 1617 1617
Partials 660 660 🚀 New features to boost your workflow:
|
JSONbored
force-pushed
the
codex/propose-fix-for-self-host-startup-drain
branch
from
July 7, 2026 12:13
2e5ea8d to
5c81576
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
drainOrbRelaynow throws on broker/fetch failures, which can crash the self-host process inORB_RELAY_MODE=pullinstead of recording the failure and retrying.Description
.catch(...)to the initialdrainRelay()invocation insrc/server.tsthat reports the error viacaptureError(error, { kind: "orb_relay_drain" }), matching the recurring interval handler and preserving the existing retry behavior.Testing
git diff --check,npx vitest run test/unit/selfhost-monitored-work.test.ts test/unit/orb-broker-client.test.ts, andnpm run typecheck, and all checks passed.Codex Task