fix(review): ignore absent bot-owned required checks#4029
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4029 +/- ##
=======================================
Coverage 93.58% 93.58%
=======================================
Files 381 381
Lines 35483 35485 +2
Branches 13014 13015 +1
=======================================
+ Hits 33206 33208 +2
Misses 1617 1617
Partials 660 660
🚀 New features to boost your workflow:
|
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Contributor
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-07 12:24:08 UTC
⏸️ Suggested Action - Manual Review
Concerns raised — review before merging
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
JSONbored
force-pushed
the
codex/fix-self-deadlock-in-gittensory-gate
branch
from
July 7, 2026 11:32
47a6971 to
5d46bac
Compare
JSONbored
force-pushed
the
codex/fix-self-deadlock-in-gittensory-gate
branch
from
July 7, 2026 12:12
5d46bac to
5254302
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
isBotOwnedRequiredContextNameto recognize bot-owned required-context names (Gittensory Orb Review Agent, legacy gate, andGittensory Context).reduceLiveCiAggregate(REST aggregate), skip bot-owned required context names when classifying a required context that "never appeared" so they are not counted ashasMissingRequiredContextor held asanyPending.test/unit/backfill.test.tsthat asserts an otherwise-green required-CI set passes when only bot-owned required checks are absent.Testing
npx vitest run test/unit/backfill.test.ts -t "expectedCiContexts fallback" --reporter=verboseand the focused backfill tests (including the new regression) passed.npx vitest run test/unit/graphql-status-rollup.test.ts --reporter=verboseand it passed.npx vitest run test/unit/backfill.test.ts -t "fetchLiveCiAggregate" --reporter=dotand the targeted suite passed.npm run typecheckwhich failed due to pre-existing TypeScript syntax errors insrc/queue/processors.tsunrelated to this change (the semantic/typecheck failure is external to this patch).Codex Task