Skip to content

fix(review): ignore absent bot-owned required checks#4029

Merged
JSONbored merged 1 commit into
mainfrom
codex/fix-self-deadlock-in-gittensory-gate
Jul 7, 2026
Merged

fix(review): ignore absent bot-owned required checks#4029
JSONbored merged 1 commit into
mainfrom
codex/fix-self-deadlock-in-gittensory-gate

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • Prevent a self-deadlock where branch-protection can list the Gittensory gate/context checks as required and the review flow then waits forever for checks the app itself posts only later.
  • Ensure the readiness/gating logic does not treat the app's own required contexts as missing external CI that must settle before the app can publish its pending Gate check.

Description

  • Added isBotOwnedRequiredContextName to recognize bot-owned required-context names (Gittensory Orb Review Agent, legacy gate, and Gittensory Context).
  • In reduceLiveCiAggregate (REST aggregate), skip bot-owned required context names when classifying a required context that "never appeared" so they are not counted as hasMissingRequiredContext or held as anyPending.
  • Added a regression unit test in test/unit/backfill.test.ts that asserts an otherwise-green required-CI set passes when only bot-owned required checks are absent.

Testing

  • Ran npx vitest run test/unit/backfill.test.ts -t "expectedCiContexts fallback" --reporter=verbose and the focused backfill tests (including the new regression) passed.
  • Ran npx vitest run test/unit/graphql-status-rollup.test.ts --reporter=verbose and it passed.
  • Ran npx vitest run test/unit/backfill.test.ts -t "fetchLiveCiAggregate" --reporter=dot and the targeted suite passed.
  • Ran npm run typecheck which failed due to pre-existing TypeScript syntax errors in src/queue/processors.ts unrelated to this change (the semantic/typecheck failure is external to this patch).

Codex Task

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.58%. Comparing base (3a74800) to head (5254302).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4029   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files         381      381           
  Lines       35483    35485    +2     
  Branches    13014    13015    +1     
=======================================
+ Hits        33206    33208    +2     
  Misses       1617     1617           
  Partials      660      660           
Files with missing lines Coverage Δ
src/github/backfill.ts 96.95% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 7, 2026
@loopover-orb

loopover-orb Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-07 12:24:08 UTC

2 files · 2 blockers · readiness 93/100 · CI green · clean

⏸️ Suggested Action - Manual Review

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

Concerns raised — review before merging

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.
Signal Result Evidence
Code review ❌ 2 blockers No AI review summary
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 51 registered-repo PR(s), 43 merged, 570 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 51 PR(s), 570 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, TypeScript, JavaScript, Ruby, Go, Kotlin, MDX, Shell
  • Official Gittensor activity: 51 PR(s), 570 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Explain no-issue PR.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@JSONbored
JSONbored force-pushed the codex/fix-self-deadlock-in-gittensory-gate branch from 5d46bac to 5254302 Compare July 7, 2026 12:12
@JSONbored
JSONbored merged commit e86c4bd into main Jul 7, 2026
10 checks passed
@JSONbored
JSONbored deleted the codex/fix-self-deadlock-in-gittensory-gate branch July 7, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Development

Successfully merging this pull request may close these issues.

1 participant