Skip to content

test(queue): assert repair-attempt recording at execution time, not dispatch #4031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JSONbored wants to merge 1 commit into from
Closed

test(queue): assert repair-attempt recording at execution time, not dispatch #4031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/unit/queue.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6920,6 +6920,11 @@ describe("queue processors", () => {

const fanned = sent.filter((job): job is Extract<import("../../src/types").JobMessage, { type: "agent-regate-pr" }> => job.type === "agent-regate-pr");
expect(fanned.map((job) => job.deliveryId)).toContain("regate-repair:owner/agent-repo#2");
// #orb-retry-storm: the attempt is recorded at EXECUTION time (after rate-limit admission), not at
// dispatch time -- a queued-but-not-yet-run job must not count against the cap. Process the fanned-out
// job (simulating the queue consumer picking it up) before checking the recorded count.
const repairJob = fanned.find((job) => job.deliveryId === "regate-repair:owner/agent-repo#2");
await processJob(env, repairJob!);
const attemptsAfterFirst = await env.DB.prepare("select count(*) as n from audit_events where event_type = ? and target_key = ?")
.bind("agent.sweep.regate.repair_attempt", targetKey)
.first<{ n: number }>();
Expand Down
Loading