fix(review): persist linked-issue hard-rule violations past the grace window by JSONbored · Pull Request #4032 · JSONbored/loopover

JSONbored · 2026-07-07T11:09:56Z

Summary

resolveLinkedIssueHardRule is fully re-evaluated from scratch every pass: it re-parses linked issues from the PR's CURRENT body and reads each linked issue's CURRENT live state, with no memory of a prior pass's finding.
During the flag-then-close verification window (settings.linkedIssueHardRules.closeDelaySeconds), that statelessness lets a confirmed violation dodge the close two ways: (1) editing the PR body during the grace window to strip the closing reference, so the next pass sees zero linked issues; (2) the linked issue's live state changing between the violating pass and the verification pass (e.g. the assignee is removed), so the same issue number re-evaluates clean.
Adds linkedIssueHardRuleViolatedAt/linkedIssueHardRuleViolationReason columns on pull_requests (mirroring draftConversionCount's never-resets discipline and mergeBlockedReason's pairing with mergeBlockedSha) — set once on the FIRST confirmed violation, never cleared, not scoped to head SHA. mergeLinkedIssueHardRuleWithPersistedViolation merges this persisted memory with the live re-parse: a live violation always wins for the reason text (freshest), but persisted memory forces violated: true even when the live pass no longer reproduces it.

Scope

Single-purpose, additive (no existing behavior changes when no violation was ever recorded)
In wantedPaths (src/, migrations/, test/)

Validation

npm run typecheck — clean
npx vitest run test/unit/linked-issue-hard-rules.test.ts test/unit/queue.test.ts — all passing

Safety

No secrets/private terms introduced
No changes to site/, CNAME, lovable/, or the changelog

… window resolveLinkedIssueHardRule is fully re-evaluated from scratch every pass -- it re-parses linked issues from the PR's CURRENT body and reads each linked issue's CURRENT live state, with no memory of a prior pass's finding. During the flag-then-close verification window (settings.linkedIssueHardRules.closeDelaySeconds), that statelessness lets a confirmed violation dodge the close two ways: editing the PR body to strip the closing reference so the next pass sees zero linked issues, or the linked issue's live state changing (e.g. unassigned) between the violating pass and the verification pass. Add linkedIssueHardRuleViolatedAt/linkedIssueHardRuleViolationReason columns (mirroring draftConversionCount's never-resets discipline and mergeBlockedReason's pairing with mergeBlockedSha) so a PR that ever confirms a violation stays flagged for its lifetime, merged with the live re-parse result rather than replacing it.

loopover-orb · 2026-07-07T11:16:23Z

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review result - fixes required

_{Review updated: 2026-07-07 11:39:27 UTC}

8 files · 2 blockers · readiness 93/100 · CI failing · blocked

🛑 Suggested Action - Manual Review

No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

Why this is blocked

No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

CI checks failing

validate
validate-code

Signal	Result	Evidence
Code review	❌ 2 blockers	No AI review summary
Linked issue	⚠️ Missing	No linked issue or no-issue rationale found.
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (no linked issue context).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 51 registered-repo PR(s), 43 merged, 570 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 51 PR(s), 570 issue(s).
Gate result	❌ Blocking	Repo-configured hard blocker found.

Review context

Author: JSONbored
Role context: owner (maintainer lane)
Public audience mode: oss maintainer
Lane context: Repository is configured for direct PR review.
Public profile languages: Python, TypeScript, JavaScript, Ruby, Go, Kotlin, MDX, Shell
Official Gittensor activity: 51 PR(s), 570 issue(s).
PR-specific overlap: none found.

Contributor next steps

Treat this as maintainer-lane context rather than normal contributor-lane activity.
Explain no-issue PR.
Link the issue being solved, or explicitly explain why this is a no-issue PR.

Signal definitions

Related work = same linked issue, overlapping active PRs, or title/path similarity.
Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

Re-run Gittensory review

codecov · 2026-07-07T11:17:27Z

❌ 51 Tests Failed:

Tests completed	Failed	Passed	Skipped
10592	51	10541	7

View the top 3 failed test(s) by shortest run time

test/unit/mcp-server-telemetry.test.ts > MCP server telemetry > falls back when Hono does not expose an execution context

Stack Traces | 0.0117s run time

Error: Failed to resolve entry for package "@jsonbored/gittensory-engine". The package may have incorrect main/module/exports specified in its package.json.
 ❯ .../gittensory-miner/lib/opportunity-fanout.js:2:1
 ❯ src/mcp/find-opportunities.ts:11:1

test/unit/mcp-server-telemetry.test.ts > MCP server telemetry > records session-scoped MCP request errors without a tool name

Stack Traces | 0.021s run time

Error: Failed to resolve entry for package "@jsonbored/gittensory-engine". The package may have incorrect main/module/exports specified in its package.json.
 ❯ .../gittensory-miner/lib/opportunity-fanout.js:2:1
 ❯ src/mcp/find-opportunities.ts:11:1

test/unit/mcp-server-telemetry.test.ts > MCP server telemetry > records sanitized error telemetry when the MCP transport handler throws

Stack Traces | 0.182s run time

Error: Failed to resolve entry for package "@jsonbored/gittensory-engine". The package may have incorrect main/module/exports specified in its package.json.
 ❯ .../gittensory-miner/lib/opportunity-fanout.js:2:1
 ❯ src/mcp/find-opportunities.ts:11:1

View the full list of 48 ❄️ flaky test(s)

test/integration/api.test.ts > test/integration/api.test.ts