chore(cleanup): remove or wire 5 confirmed-dead exports#4047
Conversation
…rkboard, and settings-drift modules These four modules (resolveLabelingRules, explainQueueBurden, buildWorkboard, computeSettingsDrift/computeSettingsDriftForRepo) have zero production call sites anywhere in the repo despite full unit test coverage. Removing them along with their dedicated test files.
Removed its only test caller (the deleted workboard test) from adapters.test.ts and left the module and its dedicated test suite untouched -- this is forward groundwork for a not-yet-built miner-side issue-analysis feature, not dead code.
settings.privateTrustEnabled was persisted and exposed via the maintainer API but read by zero conditional logic anywhere in src/ -- only ever assigned and passed through. Its doc comment described gating "private trust signals in scoring", but this repo's house rules explicitly forbid wiring in raw trust scores, so removal is the correct disposition rather than implementing the described behavior. Removes the field from the Drizzle schema, RepositorySettings type, both repository accessors, the two API route schemas, the OpenAPI schema, the focus-manifest parser and its mirrored type in the standalone gittensory-engine package, the two .yml config examples, the settings docs page, and every test fixture that plumbed the field through. Adds migration 0122 to drop the now-unused private_trust_enabled column.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 098edbe | Commit Preview URL Branch Preview URL |
Jul 07 2026, 01:24 PM |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-07 13:33:08 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 7 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4047 +/- ##
==========================================
- Coverage 93.58% 93.56% -0.02%
==========================================
Files 382 378 -4
Lines 35534 35444 -90
Branches 13028 12998 -30
==========================================
- Hits 33253 33163 -90
Misses 1618 1618
Partials 663 663
🚀 New features to boost your workflow:
|
Summary
src/settings/settings-drift.ts(computeSettingsDrift/computeSettingsDriftForRepo) — deleted, along with its dedicated test file. Fully unit-tested but never had a production call site (route/CLI/MCP).src/review/issue-rag-wire.ts(buildIssueRagQuery) — kept. It is intentional forward groundwork for the not-yet-built miner-side issue-analysis feature (feat(miner-rag): issue-centric RAG query builder (issue title/body → embeddable query text) #2320); added a one-line comment marking it as intentionally pre-built and currently unreached, matching the existing convention for this kind of groundwork.src/review/labeling-rules.ts(resolveLabelingRules) — deleted, along with its test file.review.labeling_rulesconfig is still parsed bysrc/signals/focus-manifest.ts, but nothing ever called this function to apply it; wiring it in would be new feature work, not cleanup.src/services/queue-burden-breakdown.ts(explainQueueBurden) — deleted, along with its test file. It names itself a sibling ofscore-breakdown.ts,miner-dashboard-recommendations.ts, andagent-action-explanation-card.ts(all three ARE wired intoapi/routes.ts/mcp/server.ts/agent-orchestrator.ts), but each of those three is wired in a different way (a dedicated route, an MCP tool, an orchestrator hook) — there is no single small mechanical addition that would wire this one in the same way, so it was removed rather than inventing a new integration point.src/api/workboard.ts(buildWorkboard) — deleted, along with its test coverage. The oldest of the five, superseded, no route ever called it.settings.privateTrustEnabled— removed (field + DB column), not wired in. It was persisted and exposed via the maintainer settings API but read by zero conditional logic anywhere insrc/. Its doc comment described gating "private trust signals in scoring", which this repo's house rules explicitly forbid implementing (no raw trust scores/reward values anywhere), so removal is the only compliant disposition. Removed from the Drizzle schema, theRepositorySettingstype, both repository accessors, both API route schemas, the OpenAPI schema, the focus-manifest parser and its mirrored type in the standalonegittensory-enginepackage, both.ymlconfig examples, the settings docs page, and every test fixture that plumbed the field through. Migration0122_drop_private_trust_enabled.sqldrops the column.Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally — full unsharded run green (this PR is deletion-only onsrc/**, so it adds no uncovered lines/branches)npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderate— 0 vulnerabilitiesnpm run db:migrations:checkandnpm run db:schema-drift:check— both clean (new migration0122_drop_private_trust_enabled.sql)npm run test:ci(all CI jobs) run locally end-to-end — greenSafety
privateTrustEnabledfield is removed from the OpenAPI schema and its parity check passes).UI Evidencesection with screenshots. — The onlyapps/gittensory-ui/**change is a one-sentence prose trim on the/docs/tuningsettings-reference page (removing the mention of the now-deletedprivateTrustEnabledfield); it is a text-accuracy fix with no layout/visual/interaction change, so no screenshot is attached..ymlconfig examples and the tuning docs page);CHANGELOG.mditself is untouched (not a release-prep PR).Notes
privateTrustEnabledremoval) plus the rebase onto currentmain.origin/mainwith no conflicts.Closes #4012