Skip to content

fix(commands): honor pause for configuration comments #4077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 8, 2026
Merged

fix(commands): honor pause for configuration comments #4077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/queue/processors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11113,14 +11113,14 @@ async function maybeProcessConfigurationCommand(
return true;
}
const mode = resolveAgentActionMode({
globalPaused: isGlobalAgentPause(env),
globalPaused: isGlobalAgentPause(env) || (await isGlobalAgentFrozen(env)),
agentPaused: settings.agentPaused,
agentDryRun: settings.agentDryRun,
});
const body = sanitizePublicComment(
[AGENT_COMMAND_COMMENT_MARKER, "", summarizeEffectiveConfig(settings, mode), "", "---", gittensoryFooter()].join("\n"),
);
await createIssueComment(env, req.installationId, req.repoFullName, req.issueNumber, body);
await createOrUpdateAgentCommandComment(env, req.installationId, req.repoFullName, req.issueNumber, body, mode);
await recordAuditEvent(env, {
eventType: "github_app.configuration_posted",
actor: req.actor,
Expand Down
35 changes: 34 additions & 1 deletion test/unit/queue.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ import {
markAiReviewPublished,
recordReviewSuppression,
listReviewSuppressions,
setGlobalAgentFrozen,
} from "../../src/db/repositories";
import { agentMaintenanceHeadMatchesGate, changedPathsForGuardrail, claimAiReviewLock, claimPrActuationLock, contributorEvidenceBatchSize, enrichOpenPullRequestsWithChangedFiles, processJob, reconcileLiveDuplicateSiblings, releaseAiReviewLock, releasePrActuationLock, SWEEP_FANOUT_RESOLUTION_CONCURRENCY } from "../../src/queue/processors";
import type { PullRequestRecord } from "../../src/types";
Expand Down Expand Up @@ -10752,9 +10753,11 @@ describe("queue processors", () => {
let postedBody: string | undefined;
vi.stubGlobal("fetch", async (input: RequestInfo | URL, init?: RequestInit) => {
const url = input.toString();
const method = init?.method ?? "GET";
if (url.includes("/access_tokens")) return Response.json({ token: "installation-token" });
if (url.includes("/collaborators/") && url.includes("/permission")) return Response.json({ permission: "admin" }); // maintainer
if (url.includes("/issues/77/comments")) {
if (url.includes("/issues/77/comments") && method === "GET") return Response.json([]);
if (url.includes("/issues/77/comments") && method === "POST") {
postedBody = init?.body ? JSON.parse(init.body.toString()).body : undefined;
return Response.json({ id: 5 }, { status: 201 });
}
Expand All @@ -10770,6 +10773,36 @@ describe("queue processors", () => {
expect(audit?.outcome).toBe("completed");
});

it.each([
["env pause", async (env: Env) => { (env as Env & { AGENT_ACTIONS_PAUSED: string }).AGENT_ACTIONS_PAUSED = "true"; }, "paused"],
["repo pause", async (env: Env) => { await upsertRepositorySettings(env, { repoFullName: "JSONbored/gittensory", agentPaused: true }); }, "paused"],
["repo dry-run", async (env: Env) => { await upsertRepositorySettings(env, { repoFullName: "JSONbored/gittensory", agentDryRun: true }); }, "dry_run"],
["DB global freeze", async (env: Env) => { await setGlobalAgentFrozen(env, true); }, "paused"],
] as const)("configuration respects %s — never posts the effective-config comment live", async (_label, applyPause, expectedMode) => {
const env = createTestEnv({ GITHUB_APP_PRIVATE_KEY: await generatePrivateKeyPem() });
await setupPlannerRepo(env);
await applyPause(env);
const calls = { commentPosts: 0 };
vi.stubGlobal("fetch", async (input: RequestInfo | URL, init?: RequestInit) => {
const url = input.toString();
const method = init?.method ?? "GET";
if (url.includes("/access_tokens")) return Response.json({ token: "installation-token" });
if (url.includes("/collaborators/") && url.includes("/permission")) return Response.json({ permission: "admin" });
if (url.includes("/issues/77/comments") && method === "GET") return Response.json([]);
if (url.includes("/issues/77/comments") && method === "POST") {
calls.commentPosts += 1;
return Response.json({ id: 5 }, { status: 201 });
}
return new Response("not found", { status: 404 });
});

await processJob(env, plannerWebhook("@gittensory configuration", "maintainer1"));

expect(calls.commentPosts).toBe(0);
const audit = await env.DB.prepare("select json_extract(metadata_json, '$.mode') as mode from audit_events where event_type = ?").bind("github_app.configuration_posted").first<{ mode: string }>();
expect(audit?.mode).toBe(expectedMode);
});

it("configuration: a non-maintainer is denied — nothing is posted and a skip is recorded", async () => {
const env = createTestEnv({ GITHUB_APP_PRIVATE_KEY: await generatePrivateKeyPem() });
await setupPlannerRepo(env);
Expand Down