fix(settings): preserve install-wide GLOBAL_CONTRIBUTOR_OPEN_ITEM_CAP (do not clamp to per-repo cap)#4080
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4080 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 384 384
Lines 35865 35865
Branches 13160 13160
=======================================
Hits 33589 33589
Misses 1618 1618
Partials 658 658
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-08 03:36:57 UTC
⏸️ Suggested Action - Manual Review
Concerns raised — review before merging
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
6276508 to
96766f4
Compare
Motivation
GLOBAL_CONTRIBUTOR_OPEN_ITEM_CAPto the per-repoMAX_CONTRIBUTOR_OPEN_ITEM_CAP(100), which silently tightened operator-configured install-wide caps and could trigger unwanted auto-close/label actions; the install-wide verifier is capable of evaluating larger row sets and should honor larger configured caps.Description
Math.min(..., MAX_CONTRIBUTOR_OPEN_ITEM_CAP)behavior (and the now-unused import) inresolveGlobalContributorOpenItemCapso a valid integer env value is returned unchanged, and update the unit test to assert that values >100 are preserved (src/settings/global-contributor-cap.ts,test/unit/global-contributor-cap.test.ts).Testing
npx vitest run test/unit/global-contributor-cap.test.ts --reporter=verboseand the updated unit tests passed; attemptednpm run test:coverage,npm run typecheck, andnpm audit --audit-level=moderatebut those encountered unrelated, pre-existing failures or external audit errors (typecheck/reporting failures in other files and an npm audit 403) that are outside the scope of this small fix.Codex Task