fix(build): build gittensory-engine before the gittensory-api deploy - #4084
Conversation
…4081) src/mcp/find-opportunities.ts (since #3986) imports packages/gittensory-miner/lib/ opportunity-fanout.js (committed, pre-built), which imports @jsonbored/gittensory-engine. That package's dist/ is gitignored and only exists after an explicit build step -- Cloudflare's Workers Builds pipeline for gittensory-api runs npm run deploy:api directly with no such step, so wrangler deploy's bundler has failed to resolve the import on every push to main since 487d26a (2026-07-07T09:36:46Z). Mirrors the identical fix already applied to the self-host image build (#4034), the release build (#4063), and the backend test suite (#4036).
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4084 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 384 384
Lines 35827 35827
Branches 13150 13150
=======================================
Hits 33548 33548
Misses 1618 1618
Partials 661 661 🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-08 00:06:43 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 4 non-blocking
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
gittensory-apihas failed on every push tomainsince487d26ac(PR feat(mcp): add gittensory_find_opportunities to hosted Worker (#2308) #3986, 2026-07-07T09:36:46Z):wrangler deploy's bundler can't resolve@jsonbored/gittensory-enginebecausepackages/gittensory-miner/lib/opportunity-fanout.js(committed, pre-built, newly reachable fromsrc/mcp/find-opportunities.tssince feat(mcp): add gittensory_find_opportunities to hosted Worker (#2308) #3986) imports it, and that package'sdist/is gitignored and only produced by an explicit build step that Cloudflare'snpm run deploy:apinever runs.mv packages/gittensory-engine/dist /tmp/... && wrangler deploy --dry-runfails withCould not resolve "@jsonbored/gittensory-engine") and confirmed the fix resolves it (same repro, now clean).Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally — this is a one-linepackage.jsonscript change with nosrc/**lines touched, socodecov/patchhas nothing to measure here; ran the full suite anyway as part ofnpm run test:ci.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
npmscript string inpackage.json), not application logic — nothing undersrc/**changed. Verified instead by direct reproduction of the actual failure and fix againstwrangler deploy --dry-run(see Summary). Matches precedent: the three prior identical fixes (fix(selfhost): build gittensory-engine before bundling the self-host image #4034, fix(ci): build engine package before the release self-host bundle #4063, fix(ci): build engine package before running backend tests #4036) were also pure build-config changes with no test additions.Safety
UI Evidencesection below with screenshots. (N/A — no visible UI change.)UI Evidence
N/A — no visible UI, frontend, docs, or extension changes.
Notes
gittensory-apiWorker is currently ~60 commits behindmain(last successful deploy: 2026-07-07T09:33:24Z) as a result of this being broken; merging this should let the very next push tomainredeploy it and catch back up automatically.