fix(db): reject code-span linked issue matches#4089
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4089 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 384 384
Lines 35865 35868 +3
Branches 13160 13160
=======================================
+ Hits 33589 33592 +3
Misses 1618 1618
Partials 658 658
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-08 03:25:41 UTC
⏸️ Suggested Action - Manual Review
Concerns raised — review before merging
Linked issue satisfactionNot yet addressed Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
9303bb4 to
bc7ecf5
Compare
Motivation
Fixesnot a directive#42cannot be treated as a valid linked-issue reference.(e.g.Closes feat(data): add contributor reconciliation reports #123)) while avoiding the new false-positive introduced by whitespace replacement.Description
extractLinkedIssueNumbersWithOverflowto scan the originaltextand compute inline code-span ranges (regex:/`[^`\n]*`/g) and skip any closing-keyword regex match that overlaps a code span; the closing-keyword regex remains the same. (file:src/db/repositories.ts)test/unit/db-parsers.test.ts)worker-configuration.d.ts).Testing
npm run typecheckwhich completed successfully (no TypeScript errors).npx vitest run test/unit/db-parsers.test.tsand the updated unit tests passed (45 testspassed).npm run test:ci; it initially reported staleworker-configuration.d.ts(fixed by regenerating types), then the full coverage run stalled in unrelated queue test output and was interrupted (not a regression in the linked-issue change).--coverageexercised the tests but the coverage remapping failed downstream withTypeError: jsTokens is not a function(an unrelated coverage remapping/tooling issue).npm audit --audit-level=moderatecould not complete in this environment (npm audit endpoint returned403 Forbidden).Codex Task