fix(review): persist merge train settings paths#4130
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 2ab91d3 | Commit Preview URL Branch Preview URL |
Jul 08 2026, 06:06 AM |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4130 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 384 384
Lines 35853 35855 +2
Branches 13157 13158 +1
=======================================
+ Hits 33574 33576 +2
Misses 1618 1618
Partials 661 661
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-08 06:58:40 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 5 non-blocking
Concerns raised — review before merging
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Motivation
mergeTrainModesetting was normalized in-memory but was not accepted by the maintainer settings API, not parsed from.gittensory.yml, and not present in the engine settings type, so persisted rows kept the SQL defaultoffand the merge-train gate could not be enabled.Description
mergeTrainModeto the maintainer settings schema so the authenticatedPUT /v1/repos/:owner/:repo/settingsendpoint accepts"off" | "audit" | "enforce"(src/api/routes.ts).settings.mergeTrainModefrom focus-manifest overrides and include it in the focus-manifest allowlist so.gittensory.ymlcan override this setting (packages/gittensory-engine/src/focus-manifest.ts).mergeTrainModeto the manifest dependency types (packages/gittensory-engine/src/types/manifest-deps-types.ts).test/integration/api.test.ts,test/unit/focus-manifest.test.ts).Testing
npm run build:minerand the build succeeded.npx vitest run test/unit/repository-settings-merge-train-mode.test.ts test/unit/focus-manifest.test.ts test/integration/api.test.tsand all tests passed (3 test files, 572 tests total passed).npm run typecheckandgit diff --checkwhich both succeeded locally.npm audit --audit-level=moderatebut the registry audit endpoint returned403 Forbiddenin this environment so the audit could not complete.Codex Task