fix(queue): keep gate enforcement while autoreview is paused#4138
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4138 +/- ##
=======================================
Coverage 93.68% 93.68%
=======================================
Files 384 384
Lines 36007 36007
Branches 13213 13212 -1
=======================================
Hits 33733 33733
Misses 1618 1618
Partials 656 656
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-08 07:36:01 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 5 non-blocking
Concerns raised — review before merging
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Motivation
reReviewStoredPullRequestwhen agithub_app.autoreview_pausedaudit row existed, which skipped live resync, gate computation, andmaybeRunAgentMaintenance, widening the pause beyond its intended AUTO-REVIEW scope.Description
reReviewStoredPullRequestwith a boolean flag:const autoreviewPaused = await hasAutoreviewPausedMarker(...)so the stored re-review continues through resync/readiness and maintenance.autoreviewPausedflag into themaybePublishPrPublicSurfacecall by settingskipAiReviewwhenoptions.skipAiReview || autoreviewPausedso only AI/public-surface work is suppressed.test/unit/queue.test.tsto assert that AI/comment output remains suppressed while the gate check-run is still written.src/queue/processors.tsandtest/unit/queue.test.ts.Testing
git diff --checkwhich succeeded.npm test -- test/unit/queue.test.ts -t "skips AI review but still enforces the gate once a PR has an autoreview pause marker" --reporter=verboseand it passed (Tests 1 passed | 702 skipped).npm run typecheckwhich completed without errors.npm run test:ciwhich aborted atcf-typegen:checkdue to a stale generatedworker-configuration.d.tsunrelated to this change, so full CI remains blocked by that generated-artifact drift.Codex Task