fix(review): keep priority propagation strict#4491
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4491 +/- ##
=======================================
Coverage 94.12% 94.12%
=======================================
Files 430 430
Lines 38181 38181
Branches 13922 13922
=======================================
Hits 35939 35939
Misses 1585 1585
Partials 657 657
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-10 07:17:44 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 1 non-blocking
Concerns raised — review before merging
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 994f99f | Commit Preview URL Branch Preview URL |
Jul 10 2026, 07:00 AM |
|
Closing — this reverts 304e88c (2026-07-09, same day), which fixed a confirmed-live bug: metagraphed PR #4554 had issue #3947 carrying both gittensor:bug and gittensor:priority, but only bug ever propagated, because GitHub silently refuses to assign a contributor lacking push/triage access — and our issues are almost always maintainer-authored for open pickup, rarely formally assigned. Without The farming concern in the new comment (a PR author citing an unrelated open maintainer issue to grab the label) is worth taking seriously, but the maintainer's hand-picking already happened when the issue was labeled If there's a real farming vector distinct from bug/feature's existing trust model, that needs a narrower guard (e.g. gate on issue age, or require the PR to reference the issue via a real closing keyword rather than just citing it) — not a blanket revert back to the broken state. |
Motivation
gittensor:prioritylabel by citing an unrelated open maintainer-authored issue in PR text.Description
trustMaintainerAuthoredIssueForRewardopt-in from thegittensor:prioritymapping in.gittensory.ymland the bundled focus manifest insrc/config/gittensory-repo-focus-manifest.tsso reward labels require direct issue authorship or assignment.prioritystrict to avoid closing-keyword farming.test/unit/gittensory-focus-manifest.test.tsto ensure the bundled mapping does not enabletrustMaintainerAuthoredIssueForReward.Testing
git diff --checkand the manifest drift verifiernpm run manifest:drift-check, both succeeded.npx vitest run test/unit/gittensory-focus-manifest.test.ts test/unit/linked-issue-label-propagation-fetch.test.ts, all unit tests executed for these files passed.npm run test:ci) could not fully complete due to unrelated infra checks:cf-typegen:checkflagged stale generated worker types andnpm audit --audit-level=moderatereturned a403from the npm audit endpoint, so the full CI sweep was not completed in this environment.Codex Task