fix(db): resolve migration number collision at 0131#4555
Conversation
Two already-merged PRs (#4544 impact-map query cache, #4545 screenshot-table gate matrix) both claimed migrations/0131, so db:migrations:check fails on main. Renumber the more-recently-merged file to 0133 (the next free slot, since 0132 is claimed by an in-flight PR) to restore a contiguous sequence.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4555 +/- ##
=======================================
Coverage ? 94.07%
=======================================
Files ? 427
Lines ? 37938
Branches ? 13851
=======================================
Hits ? 35692
Misses ? 1586
Partials ? 660 🚀 New features to boost your workflow:
|
The prior commit skipped straight to 0133, leaving a gap at 0132 -- CI correctly caught it (db:migrations:check enforces a contiguous sequence with no skipped numbers). 0132 is the actual next-free number in this branch considered on its own.
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-10 01:57:40 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 6 non-blocking
Concerns raised — review before merging
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
|
Superseded by #4554, which merged the identical fix (renumbering |
Summary
db:migrations:checkcurrently fails onmain: two already-merged PRs each independently claimedmigrations/0131—fix(review): cache impact-map's per-file vector query results) —0131_impact_map_query_cache.sqlfeat(review): viewport x theme completeness matrix for the screenshot-table gate) —0131_screenshot_table_gate_matrix.sqlBoth merged with the same number, so the sequence is no longer contiguous. This renumbers the more-recently-merged file (
impact_map_query_cache, confirmed viagit log) to0133— the next free slot — restoring a contiguous, collision-free sequence. No column/table/logic changes; a pure rename (git mv), and no test or source file references the old filename or number.Discovered while working on an unrelated feature branch and fixed as its own small, dedicated change per repo convention (own commit for discovered drift, not folded into unrelated feature work).
Test plan
npm run db:migrations:check— now reports a clean, contiguous0001..0133sequencenpm run db:schema-drift:check— cleannpx tsc --noEmit— clean