Skip to content

feat(miner-ui): scaffold apps/gittensory-miner-ui dashboard shell - #4575

Merged
JSONbored merged 2 commits into
JSONbored:mainfrom
RealDiligent:feat/miner-ui-scaffold-4303
Jul 10, 2026
Merged

feat(miner-ui): scaffold apps/gittensory-miner-ui dashboard shell#4575
JSONbored merged 2 commits into
JSONbored:mainfrom
RealDiligent:feat/miner-ui-scaffold-4303

Conversation

@RealDiligent

Copy link
Copy Markdown
Contributor

Summary

  • Add \�pps/gittensory-miner-ui/\ as a local-only Vite + TanStack Router SPA scaffold for the miner dashboard shell
  • Wire the new workspace into root \ui:*\ scripts and CI \ui\ path filters (unlike the earlier closed feat(miner-ui): scaffold apps/gittensory-miner-ui/ dashboard shell (#4303) #4571 scaffold PR, which left root CI unwired)
  • README documents why deploy model differs from \�pps/gittensory-ui\ (no TanStack Start / Cloudflare / @lovable.dev/*)

Supersedes closed #4572. Prior overlap with #4571 is resolved — that PR is closed and this branch includes the CI integration called out as missing there.

Closes #4303

Test plan


  • pm run build --workspace=@jsonbored/gittensory-miner-ui\

  • pm run typecheck --workspace=@jsonbored/gittensory-miner-ui\

  • pm run test --workspace=@jsonbored/gittensory-miner-ui\

  • pm run lint --workspace=@jsonbored/gittensory-miner-ui\
  • CI green on upstream PR

Made with Cursor

Add a local-only Vite + TanStack Router SPA scaffold for the miner
dashboard, wire it into root ui:* scripts and CI path filters.

Closes JSONbored#4303

Co-authored-by: Cursor <cursoragent@cursor.com>
@RealDiligent
RealDiligent requested a review from JSONbored as a code owner July 10, 2026 04:53
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

Co-authored-by: Cursor <cursoragent@cursor.com>
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.10%. Comparing base (3f23c61) to head (7f0f1a4).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4575   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files         427      427           
  Lines       38022    38022           
  Branches    13877    13877           
=======================================
  Hits        35779    35779           
  Misses       1586     1586           
  Partials      657      657           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 10, 2026
@loopover-orb

loopover-orb Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-10 05:08:03 UTC

18 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

⏸️ Suggested Action - Manual Review

  • Touches a guarded path — held for manual review: This PR changes guardrail-protected path(s): .github/workflows/ci.yml (matched .github/workflows/**).

Review summary
This PR scaffolds apps/gittensory-miner-ui as a local-only Vite + TanStack Router SPA shell and, unlike the closed #4571 attempt, correctly wires the new workspace into root ui:build/ui:lint/ui:typecheck/ui:test scripts and the CI 'ui' path filter (package.json script changes, .github/workflows/ci.yml:73 adding 'apps/gittensory-miner-ui/**'). It closes issue #4303, contains no schema/migration surface or gate/signals logic, and the generated routeTree.gen.ts is properly excluded from lint (eslint.config.js:9) and matches the TanStack Router plugin's expected output shape. The change is narrow and internally consistent with its stated scope.

Nits — 7 non-blocking
  • apps/gittensory-miner-ui/src/app.test.tsx only renders IndexPage; __root.tsx's layout/nav Link has no render test.
  • apps/gittensory-miner-ui/package.json pins vite at ^7.3.1 which has several open OSV advisories (unknown severity, dev-only); the lockfile already resolves the nested copy to 7.3.6, so bump the manifest floor to match.
  • Patch coverage on this addition is thin relative to source size, but apps/** sits outside the repo's src/**-scoped 97% coverage gate, so this is advisory only.
  • Add a basic render test for RootLayout (apps/gittensory-miner-ui/src/routes/__root.tsx) asserting the nav Link renders, mirroring the existing app.test.tsx pattern.
  • Bump the vite dependency floor in apps/gittensory-miner-ui/package.json from ^7.3.1 to ^7.3.6 to match the already-resolved lockfile version.
  • Diff looks like trivial or whitespace-only churn — Reduce whitespace-only or formatting-only churn and keep the diff focused on substantive changes.
  • Touches a guarded path — held for manual review — A maintainer must review and merge this change.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #4571, #4572, #4303
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (3 linked issues).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 314 registered-repo PR(s), 128 merged, 19 issue(s).
Contributor context ✅ Confirmed Gittensor contributor RealDiligent; Gittensor profile; 314 PR(s), 19 issue(s).
Gate result ⚠️ Not blocking Advisory; not blocking this PR.
Linked issue satisfaction

Addressed
The diff adds apps/gittensory-miner-ui as a routing/layout-only Vite + TanStack Router SPA matching gittensory-ui's stack (React 19, Tailwind v4, matching eslint/prettier/script conventions), explicitly omits wrangler and @​lovable.dev/vite-tanstack-config, and documents that decision in README.md exactly as the issue requested, with only a placeholder index route (no data views), consistent with t

Review context
  • Author: RealDiligent
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 314 PR(s), 19 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/ desktop before / after /
/ mobile before / (mobile) after / (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@JSONbored
JSONbored merged commit 6e1493a into JSONbored:main Jul 10, 2026
9 checks passed
@loopover-orb loopover-orb Bot added gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. and removed gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jul 10, 2026
@JSONbored JSONbored added gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. and removed gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. manual-review Gittensor contributor context

Development

Successfully merging this pull request may close these issues.

feat(miner-ui): scaffold apps/gittensory-miner-ui/ dashboard shell

2 participants