fix(db): renumber the two newer 0134 migrations to resolve the 0134 collision#4581
Merged
Conversation
…PRs) Three already-merged PRs independently claimed 0134 (#4549's review_targets_cadence_idx, #4558's predicted_gate_calls, and #4563's pr_last_backlog_convergence_regated_at). CI on this branch inherits main's full migrations/ directory regardless of which PR fixes it, so this can't be deferred to a separate PR without also blocking this one. Renumber the two newer files (keeping #4563's oldest 0134 file in place); this branch's own new migration was already moved to 0138 to stay clear of both this collision and #4563's separate 0135 collision.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4581 +/- ##
=======================================
Coverage ? 94.12%
=======================================
Files ? 429
Lines ? 38131
Branches ? 13905
=======================================
Hits ? 35889
Misses ? 1585
Partials ? 657 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0134(feat(review): add a submission-cadence/inter-arrival-time signal to flag machine-paced submitters #4549'sreview_targets_cadence_idx, feat(review): record MCP predicted-gate verdicts and measure predicted-vs-live gate agreement #4558'spredicted_gate_calls, fix(review): harden backlog-convergence-sweep against duplicate work #4563'spr_last_backlog_convergence_regated_at), socheck-migrationsfails onmainand every open PR inherits the duplicate.0134_pr_last_backlog_convergence_regated_at.sql, which pairs with0135_backlog_convergence_fanout_marker.sqlfrom the same PR) at0134, and renumbers the two later ones to the next free numbers, preserving merge order:0134_review_targets_cadence_idx.sql→0136,0134_predicted_gate_calls.sql→0137.git mvrenames — no SQL content changes (0 insertions / 0 deletions). The three migrations touch independent objects (apull_requestscolumn, areview_targetsindex, a new table), so ordering is unaffected. Same shape as the earlier 0131 collision fix (fix(db): renumber impact-map-query-cache migration to resolve 0131 collision #4554).Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.mainblocking every other PR's CI, not tied to a filed issue (same as fix(db): renumber impact-map-query-cache migration to resolve 0131 collision #4554's precedent).Validation
git diff --checknpm run actionlint(vianpm run test:ci)npm run typechecknpm run test:coveragelocally — no source lines changed (pure file rename), nothing new to covernpm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderatenpm run db:migrations:check→140 migrations OK — contiguous 0001..0137, no new duplicates. Next free: 0138Safety
UI Evidence— N/A, no visible/UI change (pure migration file rename).Notes