feat(app): display decision snapshot replay details - #482
Merged
JSONbored merged 1 commit intoJun 10, 2026
Conversation
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
JSONbored
approved these changes
Jun 10, 2026
JSONbored
left a comment
Owner
There was a problem hiding this comment.
@bittoby this is good to land.
A few notes:
- The snapshot replay is wired into the real Agent runs detail surface.
- Public-safe vs authenticated views are structurally separated.
- Tests cover stale/missing/private states and public leakage.
- The evidence formatting is not ideal, but the required screenshots are present.
- No code changes requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reason/facts/assumptionsare shown only to authenticated viewers and withheld (with an explicit notice) in the public-safe view.buildSnapshotReplayView) with focused unit tests for populated / stale / missing / private states. No schema, API/OpenAPI, or migration changes.Closes #285
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally; global coverage stays at or above 97% for lines, statements, functions, and branches (aim for 98%+ branch coverage locally so CI variance does not fail near the threshold)npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderatenpm run test:cipasses end to end. Coverage (src/**scope): statements 99.07%, branches 97.05%, functions 98.52%, lines 99.71% (all ≥ 97%).npm auditreports 0 vulnerabilities. The new view-model is unit-tested bytest/unit/snapshot-replay-ui.test.ts(8 tests: populated, stale, missing, missing-provenance, authenticated counterfactuals, public-safe withholding with a leakage assertion, target filtering, and defensive parsing). Note:apps/**is outside thesrc/**coverage scope, so these UI additions do not affect the global coverage gate.If any required check was skipped, explain why:
npm run test:cigate was run locally and passed.Safety
reason/facts/assumptions; provenance exposes only structured identifiers, enums, and timestamps. A unit test asserts the serialized public view excludes the private detail.ui:openapi:checkclean)./v1/agent/runsdata; missing/stale states are derived from real evidence, with no mock/demo fallback.UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
Agent runs → run detail → Snapshot replay. The audience toggle switches between the authenticated and public-safe views; private counterfactual detail is shown only when authenticated and withheld for the public-safe view.
Notes
apps/gittensory-ui/src/lib/snapshot-replay.ts(view-model + tests target),apps/gittensory-ui/src/components/site/snapshot-replay.tsx(SnapshotReplay+SnapshotReplayCardtoggle),apps/gittensory-ui/src/routes/app.runs.tsx(wires it into run detail),test/unit/snapshot-replay-ui.test.ts.