fix(auth): scope issue-quality reports to repo access#483
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 85a8bf8 | Commit Preview URL Branch Preview URL |
Jun 10 2026, 05:52 AM |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
This was referenced Jun 9, 2026
This was referenced Jun 10, 2026
JSONbored
force-pushed
the
codex/fix-issue-quality-reports-access-checks
branch
from
June 10, 2026 05:50
70585dc to
85a8bf8
Compare
Closed
12 tasks
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
authenticatePrivateTokenaccepts session tokens and the loader returned cached snapshots without caller-scoped authorization, exposing private issue titles and triage signals.issue-qualitypayloads so sessions cannot enumerate private repo metadata.Description
requireSessionRepoAccessbefore returning/v1/repos/:owner/:repo/issue-qualityinsrc/api/routes.tsso session callers must have repo access before the report is loaded.isIssueQualityPathmatcher and allow the route to be considered by session path-scoping helpers so the global protected-route middleware and route-specific guard work together.canAccessRepoto the MCP server and gategittensory_get_issue_qualityinsrc/mcp/server.tsto return a non-leaking forbidden payload when the caller lacks access.403on the REST endpoint and that the MCP tool returns a forbidden payload without leaking snapshot contents (test/integration/api.test.tsandtest/unit/mcp-upstream.test.ts).Testing
npm exec vitest run test/unit/mcp-upstream.test.ts test/integration/api.test.ts -- --reporter=verboseand the tests passed.npm run typecheckand the TypeScript check completed successfully.403with{ error: "forbidden_repo" }for unrelated sessions and MCP returns a{ status: "forbidden", repoFullName }payload without exposing sensitive report fields.Codex Task