fix(review): resync bot re-entry before skipping#5151
Merged
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
JSONbored
force-pushed
the
codex/fix-bot-author-re-entry-skip-issue
branch
from
July 12, 2026 09:03
b763aaa to
04d513e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5151 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 473 473
Lines 39965 39967 +2
Branches 14570 14570
=======================================
+ Hits 37704 37706 +2
Misses 1585 1585
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
reReviewStoredPullRequestuntil after a live PR resync and preserve the pre-resync stored head SHA for comparison by introducingstoredHeadShaBeforeResyncandautomationBotSkipEnabledchecks insrc/queue/processors.ts.live.head.sha === storedHeadShaBeforeResync, so a failed fetch or a drifted head falls through to the full review and gate path.isTrustedAutomationBotAuthordoc comment insrc/settings/automation-bot-skip.tsto clarify that stored authorship is a necessary precondition (not sufficient proof) for actorless skips.test/unit/queue-lifecycle-guards.test.tsand adjusttest/unit/automation-bot-skip.test.tsto exercise the unchanged-bot-head and head-drift cases, and regenerate runtime Worker types (worker-configuration.d.ts) produced by the typegen step.Testing
npx vitest run test/unit/automation-bot-skip.test.ts test/unit/queue-lifecycle-guards.test.ts -t "automation-bot-skip|isTrustedAutomationBotAuthor|isTrustedAutomationBotWebhookActor", which passed for the focused regressions.git diff --checkreturned clean results and regenerated worker types withnpm run cf-typegen, which succeeded and updatedworker-configuration.d.ts.npm run test:ci; early gate steps (typecheck, cf-typegen, etc.) completed but the full unsharded coverage run reported unrelated queue-suite timeouts/failures in the broadertest/unit/queue.*suites, so the consolidatedtest:cirun did not finish green in this environment.npm audit --audit-level=moderatewas attempted but failed due to the registry audit endpoint returning403 Forbiddenin this environment.Codex Task