fix(agent): respect dry-run for tracker auto-apply#5207
Merged
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
JSONbored
force-pushed
the
codex/fix-auto-project/milestone-write-bypass
branch
from
July 12, 2026 09:50
f8bf44e to
2d81f9f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5207 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 473 473
Lines 39973 39976 +3
Branches 14573 14574 +1
=======================================
+ Hits 37712 37715 +3
Misses 1585 1585
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
"live"Octokit, bypassing per-repoagentPaused/agentDryRun/global-freeze write suppression and audit semantics.makeInstallationOctokitsuppression hook apply to autonomous metadata writes.Description
AgentActionModeinto the project-tracker adapter API and pass it to attach calls so adapters create Octokit clients with the repository's effective action mode instead of always using"live"(src/integrations/project-tracker-adapter.ts).actionModeparameter tomaybeAutoApplyProjectOrMilestoneMatchand propagate the resolved mode from the webhook entry pointmaybeSuggestMilestoneMatchForPr(src/integrations/project-tracker-adapter.ts).actionModeat the PR webhook call site usingresolveRepoActionMode(env, settings)so per-repo/global pause and dry-run are respected (src/queue/processors.ts).dry_runand thatgithub.write.suppressedaudit rows are recorded (test/unit/project-tracker-adapter.test.ts).cf-typegendrift check (worker-configuration.d.ts).Testing
npx vitest run test/unit/project-tracker-adapter.test.tsand the updated tests passed.npm run typecheckandnpm run cf-typegen:checkand both completed successfully.npm run test:ci; it progressed through lint/migration/schema/selfhost/cf-typegen/typecheck and much of coverage, but was stopped after the coverage run exposed unrelated existing failures intest/unit/queue-5.test.tsandtest/integration/api.test.ts(these failures are outside the scope of this change).npm audit --audit-level=moderatecould not complete in this environment (npm audit endpoint returned HTTP 403).Codex Task