docs(settings): fix stale reviewEvasionProtection default claim, disclose always-on counter#5315
Merged
Merged
Conversation
…lose always-on counter Both halves of the field doc were stale: (1) "off" is no longer the default -- #4011 flipped the effective default to "close" (normalizeReviewEvasionProtection in db/repositories.ts). (2) Even explicitly set "off", detection isn't fully disabled -- the ready<->draft cycling detector unconditionally bumps a persistent DB counter for every author-driven draft conversion; only the enforcement (close action) is gated on the setting. A repo running "off" silently accumulates a cycling count, so re-enabling "close" can immediately treat a historical off-period cycle as "repeated" on the very next legitimate conversion. Fixed the same stale claim in both example yml templates (byte-synced, edited identically) and added the same caveat to the openapi occurrence. Docs-only, no behavior change. Regenerated openapi.json. Refs #5290
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 5d9cff3 | Commit Preview URL Branch Preview URL |
Jul 12 2026, 01:47 PM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5315 +/- ##
=======================================
Coverage 94.37% 94.37%
=======================================
Files 474 474
Lines 40128 40128
Branches 14631 14631
=======================================
Hits 37869 37869
Misses 1583 1583
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Closed
22 tasks
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both halves of the field doc were stale: (1) `"off"` is no longer the default — #4011 flipped the effective default to `"close"` (`normalizeReviewEvasionProtection` in `db/repositories.ts`). (2) Even explicitly set `"off"`, detection isn't fully disabled — the ready↔draft cycling detector unconditionally bumps a persistent DB counter for every author-driven draft conversion; only the enforcement (close action) is gated on the setting. A repo running `"off"` silently accumulates a cycling count, so re-enabling `"close"` can immediately treat a historical off-period cycle as "repeated" on the very next legitimate conversion — a genuine one-shot false-positive close risk.
Fixed the same stale claim in both example yml templates (byte-synced, edited identically — verified via the sync test) and added the same caveat to the openapi occurrence.
Scope
Docs-only, no behavior change. `src/types.ts`, `src/openapi/schemas.ts`, `.gittensory.yml.example`, `config/examples/gittensory.full.yml`, regenerated `openapi.json`.
Validation
Not in this PR
If the false-positive-on-reenable behavior is deemed unacceptable, a separate follow-up could snapshot/reset the counter at the moment a repo transitions away from "off" — that's a behavior change, scoped as its own issue, not bundled into this doc fix.
Closes #5290