fix(review): allowlist AWS's official example key in secret detection

[JSONbored]

Summary

• Ran a full historical audit of every PR closed/blocked for secret detection across gittensory, metagraphed, and awesome-claude. Confirmed ~20 auto-close incidents, 100% false positives (zero real leaks found in any closed PR).
• About half of those (the generic_secret_assignment class) were already fixed in fix(review): stop generic_secret_assignment from auto-closing PRs #5370. The other half is a class that hadn't been addressed: format-precise concrete kinds have zero placeholder-awareness at all — they run a bare .test() unconditionally.
• Concretely, aws_access_key false-positived 4 separate times in gittensory's own #4284 subprocess-env-redaction-helper epic — a PR building a credential-redaction feature needed a realistic-looking, inert test fixture, and used AWS's own officially published documentation placeholder, AKIAIOSFODNN7EXAMPLE (used throughout the AWS SDK's own docs and countless tutorials specifically so it's recognizable as safe — the same literal git-secrets, gitleaks, and truffleHog all already special-case).

Fix

• Added knownSafeValues?: ReadonlySet<string> to SecretPattern — an exact-match-only escape hatch, deliberately narrow (no prefix/suffix wildcards). Only aws_access_key gets an entry (AKIAIOSFODNN7EXAMPLE); every other concrete kind is untouched and stays fully unconditional.
• Added a shared secretPatternMatches() helper that checks every occurrence of a pattern in the text (not just the first), so a genuine leak elsewhere in the same diff still counts even when the known-safe example also happens to appear alongside it.
• Both hard-block consumers (secrets-scan.ts's matchedKindsIn and content-lane/security-scan.ts's scanForSecrets) now go through this shared helper instead of a bare pattern.re.test(text).

Test plan

• npm run typecheck — clean
• Added regression tests: the exact AKIAIOSFODNN7EXAMPLE literal is no longer flagged; a real AWS-shaped key is still flagged; a genuine leak alongside the known-safe example is still flagged; a pattern with no knownSafeValues behaves byte-identically to before
• Updated two pre-existing tests that used AKIAIOSFODNN7EXAMPLE as a positive fixture (asserting the old, buggy behavior) to use a real AWS-shaped literal instead, and added a dedicated negative test for the known-safe exclusion
• npx vitest run across all 6 affected test files — 277/277 passing
• npm run test:engine-parity — clean (the REES twin-pair's required marker lines are untouched; this fix is intentionally main-codebase-only since REES's output is advisory-only and never auto-closes)
• Coverage: secret-patterns.ts, secrets-scan.ts, content-lane/security-scan.ts all 100% lines / 100% branches on this diff

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.39%. Comparing base (f23886d) to head (7619eb2).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5381      +/-   ##
==========================================
- Coverage   94.43%   94.39%   -0.04%     
==========================================
  Files         551      551              
  Lines       44191    44196       +5     
  Branches    14641    14644       +3     
==========================================
- Hits        41732    41720      -12     
- Misses       1784     1801      +17     
  Partials      675      675              

Flag	Coverage Δ
shard-1	43.77% <87.50%> (-0.37%)	⬇️
shard-2	34.18% <87.50%> (-0.40%)	⬇️
shard-3	32.19% <62.50%> (+0.63%)	⬆️
shard-4	31.22% <62.50%> (-0.05%)	⬇️
shard-5	33.10% <12.50%> (-0.21%)	⬇️
shard-6	43.62% <62.50%> (+0.21%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/review/content-lane/security-scan.ts	100.00% <100.00%> (ø)
src/review/secret-patterns.ts	100.00% <100.00%> (ø)
src/review/secrets-scan.ts	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-12 16:04:25 UTC}

6 files · 1 AI reviewer · 2 blockers · readiness 93/100 · CI green · clean

⏸️ Suggested Action - Manual Review

• No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
• Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

Review summary
This PR adds an exact-match `knownSafeValues` escape hatch to `SecretPattern` for AWS's officially-published documentation placeholder (`AKIAIOSFODNN7EXAMPLE`), routes both hard-block consumers (`secrets-scan.ts` and `content-lane/security-scan.ts`) through a new shared `secretPatternMatches()` helper, and is well-tested including the multi-occurrence case (known-safe example alongside a genuine leak still flags). The implementation is narrow and correct: it checks every regex occurrence (not just the first) via a global-flag clone, correctly reuses an already-global regex's flags instead of duplicating `g`, and leaves every other pattern's `.test()` behavior byte-identical since `knownSafeValues` is optional. The external brief's 'leaked secret' flags on `AKIAIOSFODNN7EXAMPLE` occurrences are false positives — this is precisely AWS's own inert, publicly documented placeholder, which is the entire point of the PR.

Blockers

• PR description: this does not close or clearly link an eligible open issue as required for external contributor PRs; add an explicit maintainer-authorized issue link such as `Closes #NNNN`, or explain why the referenced item is the eligible issue.

Nits — 5 non-blocking

• The external brief's secret-scan flags on `AKIAIOSFODNN7EXAMPLE` literals in the diff are false positives since this is AWS's public documentation placeholder — worth confirming the repo's own gate doesn't self-flag this PR given the code being added is designed to prevent exactly that.
• secret-patterns.ts:38's `new Set([...])` for `knownSafeValues` is a fine pattern, but if a second concrete kind ever needs this treatment, consider whether per-pattern `ReadonlySet` construction should be hoisted to a shared constant to avoid re-allocating on module load for larger sets (purely stylistic at this scale).
• Consider adding a one-line comment near `secretPatternMatches` clarifying that `knownSafeValues` is intentionally exact-match-only (no substring/wildcard) so a future contributor doesn't loosen it to a `.includes()` check, which would reopen the false-negative risk for a real key that merely contains the example as a substring.
• The PR description claims this addresses '4 separate false-positive closes' in feat(miner-hands): shared subprocess redaction/env-allowlist helper in gittensory-engine #4284 — consider linking that issue directly in the PR body per the repo's issue-scope convention, since the current description references it narratively but the review guide requires an explicit closes/fixes link.
• nit: `src/review/secret-patterns.ts:17` and the AWS entry comment are much longer than the surrounding pattern table needs; I would keep the durable rationale and move incident-count detail to the PR discussion to reduce churn in this shared primitive.

Concerns raised — review before merging

• No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
• Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

Signal	Result	Evidence
Code review	❌ 2 blockers	1 reviewer
Linked issue	⚠️ Missing	No linked issue or no-issue rationale found.
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (no linked issue context).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 44 registered-repo PR(s), 36 merged, 463 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 44 PR(s), 463 issue(s).
Gate result	❌ Blocking	Repo-configured hard blocker found.
Improvement	✅ Minor	risk: clean · value: minor — Code changes are accompanied by test evidence.

Review context

• Author: JSONbored
• Role context: owner (maintainer lane)
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 44 PR(s), 463 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Treat this as maintainer-lane context rather than normal contributor-lane activity.
• Explain no-issue PR.
• Link the issue being solved, or explicitly explain why this is a no-issue PR.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @gittensory ask <question> answers contribution-quality Q&A with source citations and freshness.
• @gittensory chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review