Skip to content

refactor(rebrand): rename bot-posted check-run names and PR-comment branding#5468

Merged
JSONbored merged 1 commit into
mainfrom
loopover/checkrun-rename
Jul 12, 2026
Merged

refactor(rebrand): rename bot-posted check-run names and PR-comment branding#5468
JSONbored merged 1 commit into
mainfrom
loopover/checkrun-rename

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

Per maintainer decision, this is a hard cutover (no dual-emit transition window) for the two active check-run names:

  • Gittensory ContextLoopOver Context
  • Gittensory Orb Review AgentLoopOver Orb Review Agent

And the matching PR-comment brand strings:

  • The unified-comment headline default ("Gittensory review""LoopOver review") and reviewing-placeholder default ("Gittensory""LoopOver").
  • The "Re-run Gittensory review" checkbox label (src/queue/processors.ts, src/signals/engine.ts).
  • The "Checked by [Gittensory]" footer attribution link text (src/github/footer.ts) — the underlying URL/domain is untouched (separate, deferred).
  • The legacy panel's title/summary text (src/signals/engine.ts's panelTitle/panelSummary).

Self-host safety net: src/github/app.ts's existing finalizeLegacyPendingCheckRuns/supersedeLegacyNames mechanism — previously used only for the older "Gittensory Gate" → "Gittensory Orb Review Agent" rename — is extended with a new legacy-name constant per renamed check, so a self-hoster's PR with an already-pending check-run under the old name still gets finalized to neutral instead of hanging in_progress forever across this deploy.

Engine parity: @jsonbored/gittensory-engine (the separate, hand-duplicated predicted-gate package used for miner-side prediction) mirrors this exact rename in its own copy of evaluateGateCheckCore. The 14 golden parity fixtures are regenerated (scripts/record-engine-parity-goldens.ts) and the engine-parity drift-check (scripts/check-engine-parity.ts) confirms all 22 hand-duplicated file pairs still agree.

README's check-run disambiguation section and the OpenAPI settings descriptions (regenerated openapi.json) are updated to match.

Deliberately left untouched (each tracked by its own separate rebrand issue, or genuinely out of scope for this one):

  • gittensor — the permanent SN74 subnet brand (never renamed).
  • The repo's own name (JSONbored/gittensory) and domain (gittensory.aethereal.dev).
  • The @gittensory bot-mention command prefix and src/github/commands.ts's command titles.
  • .gittensory.yml/.gittensory-ams.yml config filenames.
  • GITTENSORY_*-prefixed env vars and npm package identifiers (@jsonbored/gittensory-mcp, etc.).
  • The bot's check-run-adjacent GitHub App slug/login (gittensory-orb[bot], gittensory[bot]) — a real, not-yet-renamed account.
  • The broader deterministic rule-finding message strings elsewhere in src/rules/advisory.ts (e.g. "Gittensory has not seen this repository...") — a much larger, separate concern from the check-run/PR-comment surface this issue scopes.

Closes #5327

Test plan

  • npm run typecheck clean
  • npm run test:ci green (781/783 test files, engine package's own 33/33, UI's own 5/5)
  • npm audit --audit-level=moderate — 0 vulnerabilities
  • npx tsx scripts/check-engine-parity.ts — all 22 hand-duplicated file pairs agree
  • Golden parity fixtures regenerated with a clean, minimal 14-file/1-line-each diff (only the title string changed)
  • Verified exact preservation of every gittensor (no-y, permanent SN74 brand) mention across all 56 touched files — zero drift
  • Rebased onto latest origin/main, resolved 2 real textual conflicts against the concurrent gateCheckMode removal (Stage and remove the derived-only gateCheckMode field (naming sprawl, #5355 follow-up) #5373) by combining upstream's new comment wording with this PR's rename

…randing

Hard cutover (maintainer decision: no dual-emit window) of the two active
check-run names ("Gittensory Context" -> "LoopOver Context", "Gittensory
Orb Review Agent" -> "LoopOver Orb Review Agent") and the matching PR-
comment brand strings: the unified-comment headline/reviewing-placeholder
defaults, the "Re-run ... review" checkbox label, the "Checked by [...]"
footer attribution, and the legacy panel's title/summary text.

The existing supersedeLegacyNames mechanism (src/github/app.ts's
finalizeLegacyPendingCheckRuns) is extended with a new legacy-name
constant for each renamed check so a self-hoster's already-pending
check-run under the old name still gets finalized to neutral instead of
hanging in_progress forever across the deploy boundary — the same
belt-and-suspenders treatment the pre-existing "Gittensory Gate" legacy
name already got from an earlier rename.

@jsonbored/gittensory-engine (the separate, hand-duplicated predicted-gate
package) mirrors this exact rename in its own copy of the same
evaluateGateCheckCore logic, with the golden parity fixtures and the
engine-parity drift-check regenerated/verified to match. README's
check-run disambiguation section and the OpenAPI settings descriptions
are updated to match.

Deliberately left untouched (each tracked by its own separate rebrand
issue or genuinely out of scope for this one): gittensor (the permanent
SN74 subnet brand), the repo's own name, the @gittensory bot-mention
command prefix, .gittensory.yml/.gittensory-ams.yml config filenames,
GITTENSORY_*-prefixed env vars, npm package identifiers, the bot's
check-run-adjacent GitHub App slug, and the broader deterministic
rule-finding message strings elsewhere in src/rules/advisory.ts.

Closes #5327
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui 46c901d Commit Preview URL

Branch Preview URL
Jul 12 2026, 09:33 PM

@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.67%. Comparing base (ecb18c1) to head (46c901d).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/signals/engine.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5468      +/-   ##
==========================================
- Coverage   94.71%   94.67%   -0.04%     
==========================================
  Files         555      555              
  Lines       44526    44528       +2     
  Branches    14664    14664              
==========================================
- Hits        42172    42157      -15     
- Misses       1619     1636      +17     
  Partials      735      735              
Flag Coverage Δ
shard-1 44.02% <56.52%> (+<0.01%) ⬆️
shard-2 35.23% <65.21%> (+<0.01%) ⬆️
shard-3 31.97% <52.17%> (-0.04%) ⬇️
shard-4 32.08% <52.17%> (+<0.01%) ⬆️
shard-5 32.73% <65.21%> (+<0.01%) ⬆️
shard-6 43.48% <34.78%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/gittensory-engine/src/advisory/gate-advisory.ts 100.00% <100.00%> (ø)
packages/gittensory-engine/src/focus-manifest.ts 99.19% <ø> (ø)
...ckages/gittensory-engine/src/review/check-names.ts 100.00% <100.00%> (ø)
src/github/app.ts 97.89% <ø> (ø)
src/github/backfill.ts 97.22% <ø> (ø)
src/github/footer.ts 100.00% <ø> (ø)
src/openapi/schemas.ts 100.00% <ø> (ø)
src/queue/ai-review-orchestration.ts 100.00% <ø> (ø)
src/queue/gate-checks.ts 100.00% <ø> (ø)
src/queue/processors.ts 95.63% <100.00%> (ø)
... and 10 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 12, 2026
@loopover-orb

loopover-orb Bot commented Jul 12, 2026

Copy link
Copy Markdown

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review result - fixes required

Review updated: 2026-07-12 21:51:08 UTC

56 files · 1 AI reviewer · no blockers · readiness 100/100 · CI failing · unstable

🛑 Suggested Action - Manual Review

  • Touches a guarded path — held for manual review: This PR changes guardrail-protected path(s): apps/gittensory-ui/public/openapi.json (matched apps/gittensory-ui/**), packages/gittensory-engine/src/advisory/gate-advisory.ts (matched packages/gittensory-engine/**), packages/gittensory-engine/src/focus-manifest.ts (matched packages/gittensory-engine/**), packages/gittensory-engine/src/review/check-names.ts (matched packages/gittensory-engine/**), packages/gittensory-engine/src/types/manifest-deps-types.ts (matched packages/gittensory-engine/**), and 12 more.

Review summary
This is a straightforward, mechanical brand-rename cutover: check-run name constants (GITTENSORY_CONTEXT/GATE → LOOPOVER_CONTEXT/GATE), PR-comment brand strings, and the footer attribution text are swapped consistently across the Worker, the engine-parity package, schemas/OpenAPI, and tests. The self-host safety net is correctly extended — a new GITTENSORY_LEGACY_ORB_GATE_CHECK_NAME is added to every supersedeLegacyNames array in src/github/app.ts (createOrUpdateGateCheckRun, Pending/Skipped/Errored/Overridden variants) so a pending 'Gittensory Orb Review Agent' run from before this deploy still gets finalized, and a new GITTENSORY_LEGACY_CONTEXT_CHECK_NAME is wired into BOT_OWNED_CHECK_NAMES (src/github/backfill.ts) to keep excluding a stale Context check from the CI-aggregate wait. The engine package (packages/gittensory-engine) mirrors the rename in its own hand-duplicated evaluateGateCheckCore, matching the stated parity goal.

Nits — 7 non-blocking
  • The linked issue Rename bot-posted check-run/status names and PR-comment branding, with a dual-emit grace period #5327 (per the external history) asks for a rename 'with a dual-emit grace period,' but this PR does a hard cutover with no dual-emit window — the description notes this is a maintainer decision, but it's worth having that override stated explicitly in the issue thread too, not just the PR description.
  • src/review/check-names.ts:13/19 embeds issue number 5327 directly in prose comments; consider a shared reference constant if this number is cited in multiple files to avoid drift if the issue number is ever corrected.
  • codecov/patch is at 95.65% vs the 99% target — worth checking which changed branches are uncovered (likely some of the newly-added legacy-name supersede paths) before merge.
  • Confirm the `GITTENSORY_LEGACY_CONTEXT_CHECK_NAME` comment's claim that this name deliberately does NOT need `finalizeLegacyPendingCheckRuns` treatment is backed by a test exercising BOT_OWNED_CHECK_NAMES with a still-pending legacy Context check.
  • Since `GITTENSORY_GATE_CHECK_NAME`/`GITTENSORY_CONTEXT_CHECK_NAME` exports were removed from `src/github/app.ts`, grep the wider codebase (outside this diff) for any remaining import of those old names to make sure nothing outside the shown files still references them.
  • PR author also opened the linked issue — Link an issue that was opened by a different contributor, or provide a rationale for why this self-authored issue represents genuine discovery work.
  • Touches a guarded path — held for manual review — A maintainer must review and merge this change.

CI checks failing

  • codecov/patch — 95.65% of diff hit (target 99.00%)
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #5327
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 44 registered-repo PR(s), 36 merged, 435 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 44 PR(s), 435 issue(s).
Gate result ⚠️ Not blocking Advisory; not blocking this PR.
Improvement ✅ Minor risk: clean · value: minor — Code changes are accompanied by test evidence.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, TypeScript, Ruby, Go, JavaScript, MDX, Shell, Solidity
  • Official Gittensor activity: 44 PR(s), 435 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/ desktop before / after /
/ mobile before / (mobile) after / (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 12, 2026
@JSONbored
JSONbored merged commit ae46bbd into main Jul 12, 2026
18 of 19 checks passed
@JSONbored
JSONbored deleted the loopover/checkrun-rename branch July 12, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename bot-posted check-run/status names and PR-comment branding, with a dual-emit grace period

1 participant