Skip to content

fix(engine): align predicted-gate collision risk with live gate#6665

Closed
RealDiligent wants to merge 1 commit into
JSONbored:mainfrom
RealDiligent:feat/critical-issue-collision-risk-parity-6629
Closed

fix(engine): align predicted-gate collision risk with live gate#6665
RealDiligent wants to merge 1 commit into
JSONbored:mainfrom
RealDiligent:feat/critical-issue-collision-risk-parity-6629

Conversation

@RealDiligent

Copy link
Copy Markdown
Contributor

Summary

  • Removes the extra issue.linkedPrs.length > 1 clause from predicted-gate buildCollisionReport risk so it matches the canonical live-gate twin in engine.ts.
  • Adds a regression test: a single freshly-linked PR stays medium risk even when the issue's stale linkedPrs field lists multiple PRs.

Closes #6629

Test plan

Made with Cursor

@RealDiligent
RealDiligent requested a review from JSONbored as a code owner July 16, 2026 17:54
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored closed this Jul 16, 2026
@JSONbored

Copy link
Copy Markdown
Owner

Above 2 PR cap.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 16, 2026
Closes JSONbored#6629

Co-authored-by: Cursor <cursoragent@cursor.com>
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.65%. Comparing base (5a2db4c) to head (ffefca4).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6665   +/-   ##
=======================================
  Coverage   93.64%   93.65%           
=======================================
  Files         680      681    +1     
  Lines       68026    68088   +62     
  Branches    18671    18692   +21     
=======================================
+ Hits        63704    63766   +62     
  Misses       3347     3347           
  Partials      975      975           
Flag Coverage Δ
shard-1 43.99% <0.00%> (+0.05%) ⬆️
shard-2 36.87% <0.00%> (-0.13%) ⬇️
shard-3 32.42% <100.00%> (+0.01%) ⬆️
shard-4 34.57% <100.00%> (+0.80%) ⬆️
shard-5 30.93% <100.00%> (-0.69%) ⬇️
shard-6 45.69% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...opover-engine/src/signals/predicted-gate-engine.ts 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(engine): predicted-gate-engine's buildCollisionReport risk check has an extra issue.linkedPrs clause its live-gate twin doesn't

2 participants