fix(ui): shared StateBoundary on public repo-quality page#6946
Closed
RealDiligent wants to merge 1 commit into
Closed
fix(ui): shared StateBoundary on public repo-quality page#6946RealDiligent wants to merge 1 commit into
RealDiligent wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing — soft-reset onto newer main accidentally staged deletions of unrelated files. Replacing with a clean PR. |
4 tasks
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Replace hand-rolled loading/error text with StateBoundary, a content-shaped skeleton, and retry wired to refetch. Distinguish HTTP failure from opt-out. Closes JSONbored#6821 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<p>branches withStateBoundary+ content-shaped skeleton (3 cards + trend table).onRetrytouseQueryrefetch; HTTP failures throw soisErrorgetsrole="alert"; successful null payload uses EmptyState.Closes #6821
UI Evidence
Test plan
role=alert+ Try again refetchesMerge ratiolabels (card + table)Supersedes closed #6944 (auto-closed on a flaky getByText for a duplicated label).
Made with Cursor