Skip to content

fix(ui): shared StateBoundary on public repo-quality page#6946

Closed
RealDiligent wants to merge 1 commit into
JSONbored:mainfrom
RealDiligent:fix/public-repo-quality-state-6821b
Closed

fix(ui): shared StateBoundary on public repo-quality page#6946
RealDiligent wants to merge 1 commit into
JSONbored:mainfrom
RealDiligent:fix/public-repo-quality-state-6821b

Conversation

@RealDiligent

Copy link
Copy Markdown
Contributor

Summary

  • Replace hand-rolled loading/error <p> branches with StateBoundary + content-shaped skeleton (3 cards + trend table).
  • Wire onRetry to useQuery refetch; HTTP failures throw so isError gets role="alert"; successful null payload uses EmptyState.

Closes #6821

UI Evidence

Before After
Before — plain loading text After — content-shaped loading skeleton

Test plan

  • Loading shows skeleton, not plain loading text
  • Error has role=alert + Try again refetches
  • Null/opt-out uses empty copy without alert
  • Success asserts tolerate duplicate Merge ratio labels (card + table)

Supersedes closed #6944 (auto-closed on a flaky getByText for a duplicated label).

Made with Cursor

@RealDiligent
RealDiligent requested a review from JSONbored as a code owner July 17, 2026 14:51
@RealDiligent

Copy link
Copy Markdown
Contributor Author

Closing — soft-reset onto newer main accidentally staged deletions of unrelated files. Replacing with a clean PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 17, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

Replace hand-rolled loading/error text with StateBoundary, a content-shaped
skeleton, and retry wired to refetch. Distinguish HTTP failure from opt-out.

Closes JSONbored#6821

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Public repo-quality page bypasses the shared loading/error state components

1 participant