fix(release): make the branch-sync step content-derived, not per-component#7128
Merged
Merged
Conversation
…onent The "Sync package-lock.json and engine-version pin" step hardcoded `for component in mcp engine miner ui-kit` against the old `release-please--branches--main--components--<name>` naming. Since linked-versions (previous commit) now puts mcp/engine/miner on ONE shared `--groups--<groupName>` branch, that hardcoded loop silently never found or synced it -- confirmed live: PR #7127's group branch left expected-engine.version stale, failing engine-parity:drift-check and two engine-version-display tests. Branches to check are now discovered via `git ls-remote --heads` against the release-please branch prefix instead of assumed by name, and the expected-engine.version sync fires on every checked-out branch (comparing its own committed pin against its own package.json) rather than an `if component == engine` check -- correct whether engine's bump lands via a solo branch or a shared group branch, and automatically adapts if the group's membership or name ever changes again. Also deleted 3 now-orphaned release-please--branches--main--components-- {engine,mcp,miner} branches left over from before this change (all their PRs were already closed/merged; linked-versions will never reuse them).
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7128 +/- ##
==========================================
+ Coverage 93.75% 95.98% +2.22%
==========================================
Files 692 609 -83
Lines 68817 48154 -20663
Branches 18781 15133 -3648
==========================================
- Hits 64520 46219 -18301
+ Misses 3302 1118 -2184
+ Partials 995 817 -178
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Sync package-lock.json and engine-version pin" step in
mcp-release-please.ymlhardcodedfor component in mcp engine miner ui-kitagainst the oldrelease-please--branches--main--components--<name>naming. Since linked-versions (#7123) now puts mcp/engine/miner on ONE shared--groups--<groupName>branch, that hardcoded loop silently never found or synced it -- confirmed live: #7127'sengine-and-dependentsgroup branch leftpackages/loopover-miner/expected-engine.versionstale, failingengine-parity:drift-checkand two engine-version-display tests (manually patched directly on that branch to unblock it in the meantime).Branches to check are now discovered via
git ls-remote --headsagainst the release-please branch prefix instead of assumed by name, and theexpected-engine.versionsync fires on every checked-out branch (comparing its own committed pin against its ownpackage.json) rather than anif component == enginecheck -- correct whether engine's bump lands via a solo branch or a shared group branch, and automatically adapts if the group's membership or name ever changes again.Also deleted the 3 now-orphaned
release-please--branches--main--components--{engine,mcp,miner}branches left over from before #7123 (all their PRs were already closed/merged; linked-versions will never reuse them).Test plan
npm run actionlint-- cleangit ls-remote --heads origin 'release-please--branches--main--*'glob matches exactly the real active release branch and nothing else (confirmed empty after deleting the 3 stale branches)