fix(scripts): document AI review-pipeline self-host env vars#7143
Conversation
gen-selfhost-env-reference.mjs's DEFAULT_SOURCE_ROOTS never scanned the AI review pipeline (src/services/ai-review.ts, src/queue/ai-review-orchestration.ts, src/queue/processors.ts), so the self-host AI_* knobs read there — AI_SUMMARIES_ENABLED, AI_PUBLIC_COMMENTS_ENABLED, AI_MAX_OUTPUT_TOKENS, AI_BYOK_DAILY_REPO_LIMIT — were missing from the generated reference despite being real self-host config a self-hoster needs. Add those three files to the scan roots and regenerate apps/loopover-ui/src/lib/selfhost-env-reference.ts. The four named vars (plus the sibling self-host vars those files read, previously undocumented for the same scan-gap reason) now appear, matching what the code actually reads. Closes JSONbored#6993
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7143 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 692 692
Lines 68832 68832
Branches 18781 18781
=======================================
Hits 64535 64535
Misses 3302 3302
Partials 995 995
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-18 00:43:23 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Closes #6993
gen-selfhost-env-reference.mjs'sDEFAULT_SOURCE_ROOTSnever scanned the AI review pipeline (src/services/ai-review.ts,src/queue/ai-review-orchestration.ts,src/queue/processors.ts), so the self-hostAI_*knobs read there —AI_SUMMARIES_ENABLED,AI_PUBLIC_COMMENTS_ENABLED,AI_MAX_OUTPUT_TOKENS,AI_BYOK_DAILY_REPO_LIMIT— were missing from the generated reference despite being real self-host config.Change
DEFAULT_SOURCE_ROOTS.apps/loopover-ui/src/lib/selfhost-env-reference.ts. The four named vars now appear, along with the sibling self-host vars those files read (previously undocumented for the same scan-gap reason) — the generator documents what the scanned files actually read.Tests
collectSelfHostEnvVarspicks up all four vars from the real repo, withAI_MAX_OUTPUT_TOKENS's first reference pinned tosrc/services/ai-review.ts.Validation
npx vitest run test/unit/selfhost-env-reference-script.test.ts— 6 passed.npm run selfhost:env-reference:check— committed reference in sync.scripts/**lines (apps/**generated file is outside Codecovcoverage.include).