chore(miner): migrate CLI command lib modules to TypeScript (batch 3.2 of 4)#7387
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7387 +/- ##
==========================================
+ Coverage 91.19% 91.20% +0.01%
==========================================
Files 716 716
Lines 72733 72758 +25
Branches 20578 20775 +197
==========================================
+ Hits 66326 66360 +34
+ Misses 5365 5356 -9
Partials 1042 1042
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…2 of 4, Phase 3) Converts plan-store-cli, run-state-cli, governor-ledger-cli, purge-cli, event-ledger-cli, and claim-ledger-cli (plus their hand-maintained .d.ts siblings) from .js to real .ts, using the in-place-emit build pipeline Phase 1 (JSONbored#7299) already wired up. No behavior change; existing tests continue to pass unmodified against the compiled output, and each converted module is covered to 100% of its statements/branches/functions/lines.
5856289 to
3d6668e
Compare
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-20 05:02:30 UTC
Review summary Nits — 5 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Closes #7306
Summary
Batch 3.2 of the #7290 migration (Phase 3, CLI command modules): converts
plan-store-cli,run-state-cli,governor-ledger-cli,purge-cli,event-ledger-cli, andclaim-ledger-cli(plus their hand-maintained.d.tssiblings) from.jsto real.ts, using the in-place-emit buildpipeline Phase 1 (#7299) already wired up. No
tsconfig.jsonchangesneeded. No behavior change; existing tests continue to pass unmodified
against the compiled output, and each converted module is driven to
100% statement/branch/function/line coverage.
Notes
had correct content and 100%
codecov/patchcoverage, but was closed by thenow-fixed repo-wide
validate/validate-tests-mergeCI infrastructureoutage, not a code issue — confirmed by inspecting its check runs before
starting this attempt.
.js/.d.tsbuild output alongsidethe
.tssources (npm run build --workspace @loopover/miner).git diff --checkagainstupstream/mainis clean (no compiled-outputtrailing-whitespace artifacts).
typecheck(root + package),actionlint,db:schema-drift:check,selfhost:env-reference:check,miner:env-reference:check,docs:drift-check,branding-drift:check,manifest:drift-check,engine-parity:drift-check,release-manifest:sync:check,command-reference:check,test:workers,build:mcp,test:mcp-pack,build:miner,test:miner-pack,test:miner-deployment-docs-audit,ui:openapi:check,ui:typecheck,ui:lint,npm audit— all clean.