feat(review): capture bounded raw context in the linked_issue_scope_mismatch fired signal#8132
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
…ismatch fired signal (JSONbored#8129)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8132 +/- ##
==========================================
- Coverage 92.02% 90.29% -1.73%
==========================================
Files 760 99 -661
Lines 77394 25751 -51643
Branches 23392 4992 -18400
==========================================
- Hits 71225 23253 -47972
+ Misses 5061 2233 -2828
+ Partials 1108 265 -843
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-23 00:17:21 UTC
Review summary Nits — 5 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
metadataat calibration: wire linked_issue_scope_mismatch into the shared signal-tracking module (fired + reversal) #8101'srecordRuleFiredcall site (src/queue/processors.ts, thelinkedIssueSatisfactionGateMode === "block" && status === "unaddressed"block) with the four bounded raw-context fields the assessment was actually based on:issueText,prTitle,prBody,diff— so Epic: verifiable pre-merge backtest for ORB/AMS deterministic rules #8082's backtest primitives can re-run a changed assessment prompt/logic against the stored corpus, not just validate confidence-floor tweaks.LinkedIssueSatisfactionInput's own constants —MAX_ISSUE_TEXT_CHARS/MAX_BODY_CHARS/MAX_DIFF_CHARSare now exported fromsrc/services/linked-issue-satisfaction.ts(values unchanged) and applied with the exact trim/slice shapesbuildLinkedIssueSatisfactionPromptitself uses, so what's stored is byte-what the assessment saw. No new bound constants, per the issue's requirement.LinkedIssueSatisfactionInputconstruction earlier in the same function) — nothing is re-fetched or re-derived.Closes #8129
Test plan
test/unit/linked-issue-satisfaction-run.test.ts: the fired event's metadata carries all four fields (issue title+body composite, exactprTitle,diffequal tobuildAiReviewDiff(files)under its bound); an over-limitprBodyis stored truncated to exactlyMAX_BODY_CHARS(the required truncation branch); a body-less PR stores an emptyprBody(the?? ""arm), never the stringnull/undefinedtoMatchObject({ confidence })assertions are unaffected by the added fieldsnpm run typecheckgreen