fix(ci): build engine before miner publish, auto-merge release-please PRs#8152
Merged
JSONbored merged 2 commits intoJul 23, 2026
Merged
Conversation
… PRs publish-miner.yml's validate job never built @loopover/engine before building miner, even though miner imports it -- engine's dist/ is gitignored, so this failed with "Cannot find module '@loopover/engine'" the first time miner's build actually exercised that import. Mirrors the existing build step already in publish-mcp.yml. Also auto-merge release-please's own Release PRs (autorelease: pending label only) once CI is green, so multiple packages' Release PRs spend less time open simultaneously -- they all share one .release-please-manifest.json, so any one merging stales every other open Release PR's copy of that file.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
User will merge Release PRs manually going forward -- no automation needed here after all. Keeps just the publish-miner.yml engine-build fix from this branch.
JSONbored
deleted the
fix/publish-miner-engine-build-and-release-automerge
branch
July 23, 2026 06:16
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8152 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 764 764
Lines 77540 77540
Branches 23436 23436
=======================================
Hits 71366 71366
Misses 5062 5062
Partials 1112 1112
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@loopover/enginebefore building miner, even though miner imports it (lib/ams-policy.tsand others) -- engine'sdist/is gitignored, so this failed withCannot find module '@loopover/engine' or its corresponding type declarationsthe first time miner's build actually exercised that import (confirmed live tonight, publish-miner.yml run 29983627469). Mirrors the existing "Build loopover-engine" step already in publish-mcp.yml.Test plan
.github/workflows/publish-miner.yml; nosrc/**changes, so no Codecov impact.