Skip to content

test(ui): cover mcp-package version selection and fallbacks - #8401

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
jsdevninja:test/mcp-package-version-coverage
Jul 24, 2026
Merged

test(ui): cover mcp-package version selection and fallbacks#8401
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
jsdevninja:test/mcp-package-version-coverage

Conversation

@jsdevninja

Copy link
Copy Markdown
Contributor

Summary

  • Closes mcp-package.ts's version-selection/fallback logic has zero test coverage #8388: adds apps/loopover-ui/src/lib/mcp-package.test.ts covering isStableVersion, getLatestMcpVersion, getRecentMcpVersions, getMcpInstallCommand, and getMcpNpxPackage.
  • Exercises stable vs prerelease gating, npm-unreachable / missing-tag fallbacks to MCP_PACKAGE_KNOWN_LATEST_VERSION, time-desc sort (insertion order ≠ time order), default/custom limit, and @latest pinning fallbacks.
  • apps/** is Codecov-ignored; no backend patch-coverage obligation.

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:test (via npm --workspace @loopover/ui run test — 82 files / 525 tests, including the new suite)
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • Test-only UI change under apps/** (Codecov ignore). Focused: npm --workspace @loopover/ui run test -- src/lib/mcp-package.test.ts (13 passing) and full @loopover/ui vitest suite green. No src/** backend changes.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — pure unit tests only; no visible UI change.

Notes

  • Pattern mirrored from apps/loopover-ui/src/lib/config-generator-yaml.test.ts.

Closes JSONbored#8388. Adds unit tests for isStableVersion, getLatestMcpVersion,
getRecentMcpVersions, getMcpInstallCommand, and getMcpNpxPackage so
prerelease and npm-unreachable fallbacks cannot silently ship.
@jsdevninja
jsdevninja requested a review from JSONbored as a code owner July 24, 2026 11:30
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 24, 2026
@loopover-orb

loopover-orb Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-24 11:35:21 UTC

1 file · 1 AI reviewer · no blockers · readiness 95/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
Test-only PR adding apps/loopover-ui/src/lib/mcp-package.test.ts covering isStableVersion, getLatestMcpVersion, getRecentMcpVersions, getMcpInstallCommand, and getMcpNpxPackage, closing issue #8388. The tests exercise real, meaningful branches (stable vs prerelease gating, missing dist-tags/time entries, insertion-order-independent time sorting, default vs custom limit, and @​latest pinning fallback for undefined/unstable versions) rather than fabricating unreachable states, and each assertion maps to a plausible real code path in the source module. Since apps/** is Codecov-ignored, there's no backend patch-coverage obligation, and CI passed on this commit.

Nits — 5 non-blocking
  • The `meta()` helper always builds `dist-tags` from a single optional `latest` field, so it can't test a `dist-tags` object present but literally empty apart from `latest` missing — verify that's the same code path as `dist-tags: {}` in mcp-package.ts (probably fine, just worth a quick sanity check).
  • The two (mcp-package.ts's version-selection/fallback logic has zero test coverage #8388) comments are the only inline comments; per repo convention they're sparse and anchor to the issue, which is good, but consider whether the second comment restating 'branch coverage matters' is necessary given the file is self-evidently a coverage-focused test suite.
  • No test explicitly exercises a `dist-tags.latest` value that is stable but has no matching `time` entry (only `getRecentMcpVersions` tests the missing-time case) — worth confirming `getLatestMcpVersion` doesn't also depend on `time` before considering coverage complete.
  • Consider a small comment or test name clarifying why `versions` for `getRecentMcpVersions` needs a `time` entry to be included, since that's a subtle real-world data quirk (npm metadata can have versions without publish times) worth flagging for future readers.
  • If `getMcpInstallCommand`/`getMcpNpxPackage` have a third state (e.g., an explicitly empty string version), add a case for it if that's a distinct branch in the source.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #8388
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 210 registered-repo PR(s), 127 merged, 39 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jsdevninja; Gittensor profile; 210 PR(s), 39 issue(s).
Improvement ℹ️ Insufficient signal risk: clean · value: insufficient-signal · LLM: moderate
Linked issue satisfaction

Addressed
The PR adds mcp-package.test.ts covering all five functions with the exact scenarios requested: stable/prerelease/malformed version gating, latest-tag fallbacks (undefined data, missing tag, unstable tag), recent-versions filtering/sorting with insertion-order-vs-time-order fixtures, default/custom limit, and install-command/npx-package pinning vs @​latest fallback for undefined and unstable versio

Review context
  • Author: jsdevninja
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 210 PR(s), 39 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Triage stale or unlinked PRs.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 4a0b136 into JSONbored:main Jul 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mcp-package.ts's version-selection/fallback logic has zero test coverage

1 participant