test(ui): cover mcp-package version selection and fallbacks - #8401
Conversation
Closes JSONbored#8388. Adds unit tests for isStableVersion, getLatestMcpVersion, getRecentMcpVersions, getMcpInstallCommand, and getMcpNpxPackage so prerelease and npm-unreachable fallbacks cannot silently ship.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-24 11:35:21 UTC
Review summary Nits — 5 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
apps/loopover-ui/src/lib/mcp-package.test.tscoveringisStableVersion,getLatestMcpVersion,getRecentMcpVersions,getMcpInstallCommand, andgetMcpNpxPackage.MCP_PACKAGE_KNOWN_LATEST_VERSION, time-desc sort (insertion order ≠ time order), default/customlimit, and@latestpinning fallbacks.apps/**is Codecov-ignored; no backend patch-coverage obligation.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:test(vianpm --workspace @loopover/ui run test— 82 files / 525 tests, including the new suite)npm audit --audit-level=moderateIf any required check was skipped, explain why:
apps/**(Codecov ignore). Focused:npm --workspace @loopover/ui run test -- src/lib/mcp-package.test.ts(13 passing) and full@loopover/uivitest suite green. Nosrc/**backend changes.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — pure unit tests only; no visible UI change.
Notes
apps/loopover-ui/src/lib/config-generator-yaml.test.ts.