fix(scripts): include jwt in FORBIDDEN_CONTENT hard-block detector#8408
Conversation
jwt is in HARD_SECRET_KINDS but was omitted from the packaged-secret copy in forbidden-content.ts, so miner/mcp tarball checks missed JWTs. Closes JSONbored#8396
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8408 +/- ##
=======================================
Coverage 92.42% 92.42%
=======================================
Files 791 791
Lines 79251 79251
Branches 23948 23947 -1
=======================================
Hits 73244 73244
Misses 4868 4868
Partials 1139 1139
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-24 12:35:39 UTC
Review summary Nits — 2 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
`jwt` is in `HARD_SECRET_KINDS` but `scripts/forbidden-content.ts` omitted it, so miner/mcp pack checks missed JWT-shaped credentials.
Add the exact `jwt` regex from `secret-patterns.ts` and correct the header. `seed_or_mnemonic` / `bittensor_key` remain excluded.
Closes #8396
Test plan
Made with Cursor