fix(ci): read Node version from .nvmrc in impact/visual workflows

[marktech0813]

Summary

• Switch gittensor-impact.yml and visual-capture-fallback.yml from hardcoded node-version: 22.23.1 to node-version-file: .nvmrc.
• Leave ui-preview-deploy.yml hardcoded — that job intentionally has no checkout, so there is no .nvmrc on the runner.

Fixes #8393

Test plan

• Diff limited to the two workflows that check out before setup-node
• CI workflow parse / dispatch smoke if available

Made with Cursor

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.52%. Comparing base (9adcccb) to head (63720db).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8431      +/-   ##
==========================================
+ Coverage   92.50%   92.52%   +0.01%     
==========================================
  Files         791      791              
  Lines       79333    79348      +15     
  Branches    23960    23970      +10     
==========================================
+ Hits        73386    73413      +27     
+ Misses       4807     4798       -9     
+ Partials     1140     1137       -3     

Flag	Coverage Δ
shard-1	53.65% <ø> (-1.86%)	⬇️
shard-2	51.09% <ø> (+1.19%)	⬆️
shard-3	58.73% <ø> (+1.86%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

[loopover-orb]

Warning

⏸️ LoopOver review result - manual review recommended

_{Review updated: 2026-07-24 15:00:42 UTC}

2 files · 1 AI reviewer · no blockers · CI green · clean

⏸️ Suggested Action - Manual Review

• Touches a guarded path — held for manual review: This PR changes guardrail-protected path(s): .github/workflows/gittensor-impact.yml (matched .github/workflows/**), .github/workflows/visual-capture-fallback.yml (matched .github/workflows/**).

Review summary
This PR swaps hardcoded `node-version: 22.23.1` for `node-version-file: .nvmrc` in the two workflows that checkout the repo before `setup-node` (gittensor-impact.yml, visual-capture-fallback.yml), while correctly leaving ui-preview-deploy.yml hardcoded since that job has no checkout step and thus no .nvmrc on the runner. Both changed workflows do have a `Checkout` step preceding `Setup Node` in the full file content shown, so `.nvmrc` will be present on the runner when `actions/setup-node` reads it. The change is minimal, correctly scoped to only the two eligible workflows, and is tied to issue #8393.

Nits — 3 non-blocking

• The PR doesn't show verification that a `.nvmrc` file actually exists at the repo root with a valid Node version string — if it's missing or malformed, `setup-node` will fail at runtime; worth confirming in the PR since it isn't part of this diff.
• Consider adding a one-line comment near `node-version-file: .nvmrc` noting why `ui-preview-deploy.yml` is deliberately excluded, mirroring what's already stated in the PR description, so a future editor doesn't 'fix' that workflow to match.
• Touches a guarded path — held for manual review — A maintainer must review and merge this change.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ⚠️ Gate result — Not blocking (Advisory; not blocking this PR.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8393
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 115 registered-repo PR(s), 18 merged, 3 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	marktech0813; Gittensor profile; 115 PR(s), 3 issue(s).
Improvement	ℹ️ Insufficient signal	risk: clean · value: insufficient-signal

Linked issue satisfaction

Partially addressed
The two required node-version-file swaps in gittensor-impact.yml and visual-capture-fallback.yml are correctly made, but the issue also explicitly required rewording ui-preview-deploy.yml's comment so it no longer cites these two workflows as sharing its no-checkout justification, and the diff shows no change to that file.

Review context

• Author: marktech0813
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 115 PR(s), 3 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Start here: Triage stale or unlinked PRs.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review