test(calibration): make signal-tracking's real coverage visible to Codecov

[cleanjunc]

Closes #8343

Summary

• packages/loopover-engine/src/calibration/signal-tracking.ts (Extract a shared, deployment-agnostic calibration/signal-tracking module for ORB + AMS #7982) — computeRulePrecision, computeRuleRepeatCount, and evaluateRuleRepeatAlarm — is fully exercised by the engine package's own node --test suite (packages/loopover-engine/test/signal-tracking.test.ts), but that runner is not part of the root vitest run Codecov reads codecov/patch from, so the module reports as ~0% covered in Codecov's eyes despite being genuinely tested. Same blind spot as fix(ci): review-enrichment's real node:test coverage is invisible to Codecov (83 of 83 files effectively unmeasured) #6250.
• Adds a root-level vitest twin, test/unit/signal-tracking.test.ts, importing the three primitives via the engine barrel (../../packages/loopover-engine/src/index) and re-exercising every scenario the package suite covers — mirroring the sibling twins test/unit/calibration-dashboard.test.ts and test/unit/discovery-soft-claim.test.ts.
• Adds a short note to the engine package README documenting the root mirror (extending the existing reviewer-consensus-calibration.ts (658 lines) is the package's largest branch surface invisible to Codecov #8349 mirror note). This README touch is deliberate and load-bearing — see "Why the README change" below.
• No change to any file under packages/loopover-engine/src/** or packages/loopover-engine/test/**.

Covers both arms of every branch in the three functions: computeRulePrecision (fired-rule filter, override rule match/no-match, reversed/confirmed verdicts, decided > 0 ? … : null both arms), computeRuleRepeatCount (both && operands' false arms via same-rule-different-target and same-target-different-rule, plus the empty-list case), and evaluateRuleRepeatAlarm (below/at-threshold boundary, seen-dedup first-seen order, other-ruleId exclusion, empty list). Locally this brings the source module to 100% line + branch under vitest.

Why the README change (please read before grading scope)

A pure test/**-only diff that touches no packages/loopover-engine/** path is classified by CI as a scoped, coverage-artifact-free run: each test shard runs vitest --changed=origin/main --coverage.all=false, produces an empty coverage/lcov.info (no changed src/**), and therefore skips uploading its coverage blob ("scoped run passed but exercised no src/** files -- skipping coverage artifacts for this shard"). With zero coverage-blob-shard-* artifacts, validate-tests-merge then fails with ENOENT … all-blob-reports, which fails validate and auto-closes the PR — which is exactly what happened to my first attempt (#8407).

The merged twin PR for #8349 avoided this by also adding a note to packages/loopover-engine/README.md. Touching an engine-package path flips CI onto the full-coverage run, whose shards upload real blobs so validate-tests-merge passes. This PR follows that established, merged precedent: the README note is genuinely useful (it documents why the root mirror exists) and keeps CI on the full-coverage path. It adds zero src/** production lines, so codecov/patch still has nothing on this diff to grade — the coverage this adds is what makes a future PR touching signal-tracking.ts gate correctly.

Scope

• The PR title follows type(scope): short summary Conventional Commit format.
• Focused: a single new test file plus a directly-related, CI-load-bearing README note (rationale above); no unrelated backend/UI/MCP/dep/deploy changes.
• Follows CONTRIBUTING.md; does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves — Closes #8343.

Validation

• git diff --check — clean.
• npm run actionlint — N/A: no workflow / composite-action changes.
• npm run typecheck — green (after building @loopover/engine, as the root test:ci sequence does before typecheck).
• npm run test:coverage locally — the new file passes (13 tests) and reports 100% line + branch coverage of signal-tracking.ts.
• npm run test:workers — N/A: no worker code changed.
• npm run build:mcp / npm run test:mcp-pack — N/A: no MCP changes.
• npm run ui:openapi:check / npm run ui:lint / npm run ui:typecheck / npm run ui:build — N/A: no UI, API, or OpenAPI surface changed.
• npm audit --audit-level=moderate — not run locally (sandbox audit endpoint returns a lockfile 400); no dependency changes, so it cannot affect the audit. CI runs it against a clean install.
• New or changed behavior has unit tests — this PR is the added test coverage; no production behavior changed.

If any required check was skipped, explain why:

• All skipped checks are N/A for a PR that adds one root-level vitest file plus a docs note, with no production, UI, MCP, API, workflow, or dependency changes.

Safety

• No secrets, wallet details, hotkeys, coldkeys, PATs, private keys, trust scores, private rankings, or maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and implies no compensation or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests — N/A: none changed.
• API/OpenAPI/MCP behavior is updated and tested where needed — N/A: none changed.
• UI changes use live API data / real empty/error/loading states — N/A: no UI changes.
• Public docs/changelogs updated where needed; CHANGELOG.md not edited (not a release-prep PR).

Notes

• The test imports the primitives from the engine barrel, not a relative path into the source file, matching every existing sibling root-level engine test.
• No behavior of signal-tracking.ts was changed, and its own node --test suite was left untouched, as the issue requires.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.44%. Comparing base (9075a2c) to head (17175fb).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #8438       +/-   ##
===========================================
+ Coverage   79.34%   92.44%   +13.09%     
===========================================
  Files         791      791               
  Lines       79289    79294        +5     
  Branches    23950    23952        +2     
===========================================
+ Hits        62915    73306    +10391     
+ Misses      13302     4847     -8455     
+ Partials     3072     1141     -1931     

Flag	Coverage Δ
shard-1	56.95% <ø> (-0.82%)	⬇️
shard-2	48.56% <ø> (+0.88%)	⬆️
shard-3	56.09% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 252 files with indirect coverage changes

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-24 13:40:40 UTC}

2 files · 1 AI reviewer · no blockers · readiness 93/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This PR adds a root-level vitest twin (test/unit/signal-tracking.test.ts) that re-exercises computeRulePrecision, computeRuleRepeatCount, and evaluateRuleRepeatAlarm via the engine barrel, purely to make Codecov's patch coverage see behavior already tested by the package's own node:test suite. The tests are well-targeted, cover both arms of every branch cited in the description (decided>0 ternary, the two && operand false-arms in computeRuleRepeatCount, the seen.has dedup arm, ruleId mismatch arms), and the accompanying README note is a one-line factual addition consistent with the existing #8349 precedent in the same file. This is a narrow, test-only diff with no src changes, closing #8343 exactly as described.

Nits — 4 non-blocking

• The long top-of-file comment in test/unit/signal-tracking.test.ts duplicates most of the PR description verbatim; a shorter pointer to calibration/signal-tracking.ts's real node:test coverage is invisible to Codecov #8343/Extract a shared, deployment-agnostic calibration/signal-tracking module for ORB + AMS #7982 would suffice.
• computeRulePrecision test cases don't cover a fired event with no corresponding override at all (only the reverse: an override with no fired event) — worth a quick scenario for symmetry, though not required by the stated branch list.
• Consider trimming the header comment in the new test file to 2-3 lines now that the PR description carries the full rationale.
• If future signal-tracking primitives are added, keep mirroring them here immediately rather than batching, to avoid recreating the same Codecov blind spot.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8343
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 53 registered-repo PR(s), 22 merged, 37 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	cleanjunc; Gittensor profile; 53 PR(s), 37 issue(s).
Improvement	ℹ️ Insufficient signal	risk: clean · value: insufficient-signal

Linked issue satisfaction

Addressed
The PR adds test/unit/signal-tracking.test.ts importing the three primitives via the engine barrel and mirrors the required scenarios (precision null/ratio/cross-rule/no-fired-match, repeat count exact-match filtering, and alarm threshold/dedup/exclusion cases), without touching any file under packages/loopover-engine/src/** or test/**.

Review context

• Author: cleanjunc
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, TypeScript, JavaScript, Scala
• Official Gittensor activity: 53 PR(s), 37 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Start here: Triage stale or unlinked PRs.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.