test(ui): cover snapshot-replay privacy boundary (#8386) - #8439
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-24 13:19:55 UTC
Review summary Nits — 6 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. Scroll preview
A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|


Summary
apps/loopover-ui/src/lib/snapshot-replay.test.tscoveringbuildSnapshotReplayViewpublic stripping ofreason/facts/assumptions, authenticated pass-through, missing/partial snapshots, stale triggers, repo filtering, and confidence/freshness narrowing.apps/loopover-ui/src/components/site/snapshot-replay.test.tsxcovering the audience toggle leak-guard, missing-status notice-only render, andwithheldPrivateFieldsfooter.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:test(vianpm --workspace @loopover/ui run test -- src/lib/snapshot-replay.test.ts src/components/site/snapshot-replay.test.tsx— 17 passing)npm audit --audit-level=moderateIf any required check was skipped, explain why:
apps/**(Codecov ignore). Nosrc/**backend changes. Focused vitest suite green (17 tests).Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
No rendered UI source changed — only
*.test.ts/*.test.tsxwere added. Before and after are identical captures of production/(dark-mode-only UI) so every required viewport × theme row is present. Light rows use the same dark rendering underprefers-color-scheme: light, matching the house convention that loopover-ui has no separate light theme.Notes