fix(docs): add the 6 missing published docs pages to the DocsNav sidebar#8476
fix(docs): add the 6 missing published docs pages to the DocsNav sidebar#8476kai392 wants to merge 1 commit into
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
miner-quickstart, loopover-commands, ai-summaries, owner-checklist, self-hosting-docs-audit, and self-hosting-unified-ams-orb all have published, cross-linked content/docs/*.mdx pages but no docsNav entry, so they were unreachable from the persistent sidebar and skipped by DocsPrevNext. Adds a drift guard so a future page that forgets its entry fails a test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-24 15:03:49 UTC
Review summary Nits — 5 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. Scroll preview
A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
This pull request changes UI/visual code but its screenshot evidence is incomplete. Every required viewport × theme combination needs its own before/after image pair in a labeled table row (e.g. "Desktop · Light | before | after"). Still missing: Desktop · Dark, Tablet · Dark, Mobile · Dark. Please resubmit with the remaining rows filled in. See https://github.com/JSONbored/loopover/blob/main/.claude/skills/contributing-to-loopover/SKILL.md for the exact format and examples. This is an automated maintenance action. |


Fixes #8385
Root cause
docsNavinapps/loopover-ui/src/components/site/docs-nav.tsxis maintained by hand alongsidedocs.index.tsx's separately-curated landing grid. Six published pages had realcontent/docs/*.mdxcontent and index-page links but nodocsNaventry:miner-quickstart,loopover-commands,ai-summaries,owner-checklist,self-hosting-docs-audit,self-hosting-unified-ams-orbBecause
DocsPrevNextbuilds its footer links from the same array viagroupItems(), those pages were both unreachable from the persistent left rail and skipped in the site-wide prev/next reading flow — no other page's "next" ever landed on them.Fix approach
Additive only — no existing entry removed or reordered. Each page went to the group the issue specified, reusing
docs.index.tsx's established label so the same page isn't described two ways:miner-quickstartloopover-commandsai-summariesself-hosting-unified-ams-orbself-hosting-docs-auditowner-checklistself-hosting-docs-auditwent to release & security rather than setup because its own frontmatter describes it as a pre-release accuracy checklist, placing it next to the existing "Release checklist" entry.docs.index.tsxis deliberately untouched, per the issue — the two navs are allowed to differ.The drift guard
New
docs-nav.test.tsx, co-located per this repo's convention and reading real files the waydocs-source-server-isolation.test.tsalready does.content/docs/is treated as the source of truth for what's published:.mdxhas a sidebar entry (the actual regression)It genuinely fails on the pre-fix state. Stashing only the
docs-nav.tsxchange and re-running reports exactly the 6 missing slugs; restoring it passes 4/4.Impact / risks
docs.$slug.tsxdynamic route — not the frozendocs.*.tsxpattern.Validation
npm --workspace @loopover/ui run test -- src/components/site/docs-nav.test.tsx— 4/4, re-run after rebasing onto currentmain(9b9924b3), since the guard asserts against the livecontent/docs/directorynpm --workspace @loopover/ui run typecheck— cleanprettier --checkclean on both changed filesapps/**is outside Codecov'scoverage.include, so this carries no patch-coverage percentage; the drift guard is the deliverable that prevents recurrence