test(engine): consolidate focus-manifest engine bolt-ons into one file#8581
Merged
Merged
Conversation
#8577) focus-manifest-engine-barrel.test.ts (a single re-export-identity check) and focus-manifest-engine-branch-coverage.test.ts (a #2280 Codecov bolt-on) both tested packages/loopover-engine/src/focus-manifest.ts from two disconnected tiny files. Merge into focus-manifest-engine.test.ts, keeping every case verbatim (a pure relocation, no case dropped or retitled logic-wise). Verified zero coverage regression on the module: branch/line coverage with {loader, validation, engine-merged} is identical to {loader, validation, barrel, branch-coverage} -- 869/1729 branches (50.26%), 727/1334 lines (54.49%) in both cases.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
loopover-orb
Bot
added
the
gittensor:bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8581 +/- ##
==========================================
- Coverage 92.54% 91.99% -0.56%
==========================================
Files 796 796
Lines 79845 79845
Branches 24134 24134
==========================================
- Hits 73896 73452 -444
- Misses 4802 5309 +507
+ Partials 1147 1084 -63
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8577.
Summary
focus-manifest-engine-barrel.test.ts(a single re-export-identity check, 24 lines) andfocus-manifest-engine-branch-coverage.test.ts(a feat(miner-foundation): extract focus-manifest parse/compile core into gittensory-engine #2280 Codecov bolt-on, 140 lines) both testedpackages/loopover-engine/src/focus-manifest.tsfrom two disconnected tiny files.focus-manifest-engine.test.ts— every case kept verbatim, a pure relocation.Test plan
npx vitest run test/unit/focus-manifest-engine.test.ts— 9/9 passnpm run typecheck— cleanpackages/loopover-engine/src/focus-manifest.ts, before (barrel + branch-coverage + loader + validation) vs after (merged + loader + validation): identical — 869/1729 branches (50.26%), 727/1334 lines (54.49%) in both cases.