test(miner): rename miner-cli-json-error-coverage.test.ts to drop the coverage-padding filename#8585
Merged
Conversation
… coverage-padding filename (#8579) Unlike the other bolt-on files in the '-coverage' family (#8574), this one is a legitimate single-concern suite: the shared --json error-envelope contract exercised across many miner CLI subcommands via one shared expectJsonError/expectJsonErrorAsync helper. Distributing it into each CLI's own sibling file would duplicate that helper and lose the "one contract, many entry points" narrative -- so this is a rename only (Option A from the issue), no content change. Also retitled the top-level describe to drop "coverage" framing and added a comment explaining why the file stays consolidated.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8585 +/- ##
==========================================
- Coverage 92.54% 91.99% -0.56%
==========================================
Files 796 796
Lines 79845 79845
Branches 24134 24134
==========================================
- Hits 73896 73452 -444
- Misses 4802 5309 +507
+ Partials 1147 1084 -63
Flags with carried forward coverage won't be shown. Click here to find out more. |
loopover-orb
Bot
added
the
gittensor:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8579.
Summary
Unlike the other bolt-on files in the '-coverage' family (#8574), this one is a legitimate single-concern suite: the shared
--jsonerror-envelope contract ({ ok: false, error }, exit code 2, nothing on stderr) exercised across many miner CLI subcommands via one sharedexpectJsonError/expectJsonErrorAsynchelper. Distributing it into each CLI's own sibling file (Option B) would duplicate that helper across ~9 files and lose the "one contract, many entry points" narrative.Went with Option A from the issue: rename only, no content change (
miner-cli-json-error-coverage.test.ts->miner-cli-json-error-paths.test.ts), retitled the top-level describe to drop the "coverage" framing, and added a comment explaining why the file stays consolidated so it doesn't get flagged again.Test plan
npx vitest run test/unit/miner-cli-json-error-paths.test.ts— 8/8 passnpm run typecheck— clean