fix(selfhost): read POSTHOG_CLI_PROJECT_ID/HOST from secrets, not vars#8621
Merged
Conversation
Both were configured as environment SECRETS in the release/release-beta GitHub environments, not variables -- vars.* and secrets.* are separate namespaces in Actions, so the workflow would have seen them as unset.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
loopover-orb
Bot
added
the
gittensor:bug
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8621 +/- ##
=======================================
Coverage 92.76% 92.76%
=======================================
Files 797 797
Lines 79355 79355
Branches 24034 24034
=======================================
Hits 73616 73616
Misses 4592 4592
Partials 1147 1147
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-applies a fix that got dropped: #8619 auto-merged with only its first commit before I pushed this fix to the same branch, so it never reached
main. Confirmed live: the actual beta build (orb-v3.4.0-beta.7) failed twice againstmainwithPOSTHOG_CLI_PROJECT_IDresolving empty, even after the value was correctly set as a secret in both environments — because the workflow was still readingvars.POSTHOG_CLI_PROJECT_ID, a different namespace fromsecrets.*.Both
POSTHOG_CLI_PROJECT_IDandPOSTHOG_CLI_HOSTwere configured as environment secrets (not variables) in therelease/release-betaGitHub environments — this switches the workflow to read them fromsecrets.*to match.Test plan
python3 -c "import yaml; yaml.safe_load(...)"— valid YAMLPOSTHOG_CLI_PROJECT_IDresolves non-empty in the run logs before declaring success