fix(orb): repair two drift checks #8841 left red on main - #8846
Conversation
- config/examples/loopover.full.yml gains the closeAuditHoldoutPct doc block its .loopover.yml.example twin gained in #8841 (the template parity test compares them from WHERE IT LIVES onward) - register loopover_close_audit_holdouts_total in DEFAULT_METRIC_META (the metrics drift guard requires every emitted literal)
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8846 +/- ##
==========================================
+ Coverage 90.56% 92.30% +1.74%
==========================================
Files 96 803 +707
Lines 22490 80028 +57538
Branches 3884 24254 +20370
==========================================
+ Hits 20367 73872 +53505
- Misses 1945 5092 +3147
- Partials 178 1064 +886
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-26 12:41:10 UTC
Review summary Nits — 3 non-blocking
Concerns raised — review before merging
📋 Copy for AI agents — paste into your coding agentDecision drivers
Context & advisory signals — never blocks the verdict
Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Main is currently red on
config-templates(the.loopover.yml.exampledoc block added in #8841 was never mirrored into itsconfig/examples/loopover.full.ymltwin) and on theselfhost-metricsdrift guard (loopover_close_audit_holdouts_totalis emitted but was never registered inDEFAULT_METRIC_META). Both repaired; 62 tests in the two suites green, TSC clean.Small and standalone so every open PR (#8843, #8845) goes green on rebase rather than each carrying the same fix. My miss in #8841 — the parity pair and the metric registry both have drift guards precisely for this, and they worked.