Skip to content

fix(orb): repair two drift checks #8841 left red on main - #8846

Merged
JSONbored merged 1 commit into
mainfrom
fix/8841-drift
Jul 26, 2026
Merged

fix(orb): repair two drift checks #8841 left red on main#8846
JSONbored merged 1 commit into
mainfrom
fix/8841-drift

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Main is currently red on config-templates (the .loopover.yml.example doc block added in #8841 was never mirrored into its config/examples/loopover.full.yml twin) and on the selfhost-metrics drift guard (loopover_close_audit_holdouts_total is emitted but was never registered in DEFAULT_METRIC_META). Both repaired; 62 tests in the two suites green, TSC clean.

Small and standalone so every open PR (#8843, #8845) goes green on rebase rather than each carrying the same fix. My miss in #8841 — the parity pair and the metric registry both have drift guards precisely for this, and they worked.

- config/examples/loopover.full.yml gains the closeAuditHoldoutPct doc
  block its .loopover.yml.example twin gained in #8841 (the template
  parity test compares them from WHERE IT LIVES onward)
- register loopover_close_audit_holdouts_total in DEFAULT_METRIC_META
  (the metrics drift guard requires every emitted literal)
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@superagent-security superagent-security Bot added pr:flagged PR flagged for review by security analysis. and removed pr:flagged PR flagged for review by security analysis. labels Jul 26, 2026
@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.30%. Comparing base (9537fef) to head (520c038).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8846      +/-   ##
==========================================
+ Coverage   90.56%   92.30%   +1.74%     
==========================================
  Files          96      803     +707     
  Lines       22490    80028   +57538     
  Branches     3884    24254   +20370     
==========================================
+ Hits        20367    73872   +53505     
- Misses       1945     5092    +3147     
- Partials      178     1064     +886     
Flag Coverage Δ
backend 92.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/selfhost/metrics.ts 100.00% <ø> (ø)

... and 706 files with indirect coverage changes

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 26, 2026
@loopover-orb

loopover-orb Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Warning

⏸️ LoopOver review result - manual review recommended

Review updated: 2026-07-26 12:41:10 UTC

2 files · 1 AI reviewer · 2 blockers · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This is a narrow, self-contained fix: it registers the missing `loopover_close_audit_holdouts_total` metric in `DEFAULT_METRIC_META` and mirrors the `closeAuditHoldoutPct` doc block into `config/examples/loopover.full.yml` to match `.loopover.yml.example`, resolving two drift checks left red by #8841. Both changes are minimal, correctly placed, and verified against the full file content — the metric key and comment text match exactly what the drift guards check for. CI is fully green (62 tests, TSC clean) and this is registry/doc-only, so no new logic paths need direct unit tests beyond the existing drift guards.

Nits — 3 non-blocking
  • The new gate.closeAuditHoldoutPct example comment block in config/examples/loopover.full.yml is commented out (`# closeAuditHoldoutPct: 5`) — confirm the parity check only compares comment text/structure and not literal active-vs-commented state, since a mismatch there would just reintroduce the same drift this PR fixes.
  • None beyond what's already done — this is a tightly scoped repair PR.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Concerns raised — review before merging

  • No linked issue detected: No closing reference or linked issue number was found in the PR metadata/body. — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue: This repo's maintainer focus manifest requires every PR to reference a tracked issue. — Link the relevant issue (for example Closes #123) before opening the PR.
📋 Copy for AI agents — paste into your coding agent
Fix the following blocker(s) from this PR review:

1. No linked issue detected: No closing reference or linked issue number was found in the PR metadata/body. — If this PR is intended to solve an issue, link it explicitly in the PR body.

2. Maintainer requires a linked issue: This repo's maintainer focus manifest requires every PR to reference a tracked issue. — Link the relevant issue (for example `Closes #123`) before opening the PR.

Decision drivers

  • ❌ Code review — 2 blockers (1 reviewer)
  • ❌ Gate result — Blocking (Repo-configured hard blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 13 registered-repo PR(s), 13 merged, 249 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 13 PR(s), 249 issue(s).
Improvement ℹ️ None detected risk: low · value: none · LLM: minor
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 13 PR(s), 249 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Then work through the remaining 2 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 26, 2026
@JSONbored
JSONbored merged commit 19158b8 into main Jul 26, 2026
7 checks passed
@JSONbored
JSONbored deleted the fix/8841-drift branch July 26, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant