fix(engine): classify 'ci' change-kind only by real CI path segments, not any .yml/.yaml (#8873) - #8921
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
… not any .yml/.yaml objective-anchor.ts's kindsFromPath tagged any YAML file as 'ci' via a bare `.yml`/`.yaml` extension fallback, so a root `.loopover.yml` or `docs/mkdocs.yml` diluted the 'ci' change-kind dimension scoreObjectiveAnchor relies on. Drop the extension fallback -- 'ci' is now classified only via a real CI path segment (CI_SEGMENTS), the same path-segment discipline every other change-kind uses. Tests: a config YAML at the repo root and docs/mkdocs.yml no longer produce 'ci'; a YAML under a real CI path segment (.github/workflows/ci.yml) still does.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8921 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 803 803
Lines 80084 80084
Branches 24277 24276 -1
=======================================
Hits 75157 75157
+ Misses 3562 3561 -1
- Partials 1365 1366 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-26 13:47:33 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Decision record
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (conflicts with the base branch — resolve and open a fresh PR). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Problem
Closes #8873.
packages/loopover-engine/src/objective-anchor.ts'skindsFromPathclassifiedciviaCI_SEGMENTS.has(segment) || filename.endsWith('.yml') || filename.endsWith('.yaml'). The bare-extension fallback tagged any YAML file — root.loopover.yml,docs/mkdocs.yml— asciregardless of location, diluting thecichange-kind dimensionscoreObjectiveAnchorrelies on.Fix
Drop the extension fallback.
ciis now classified only via a real CI path segment (CI_SEGMENTS), the same path-segment discipline every other change-kind in the function already uses.Tests
.loopover.yml(root) →configbut notci.docs/mkdocs.yml→ notci..github/workflows/ci.yml→ stillci(provesCI_SEGMENTSpath classification is unaffected).Reverting the change fails the negative assertions.
git diff --checkclean.