fix(engine): key chokepoint ledger paused off kill_switch eventType#8965
fix(engine): key chokepoint ledger paused off kill_switch eventType#8965galuis116 wants to merge 1 commit into
Conversation
Budget-cap termination fires stage budget_cap with eventType kill_switch; denyResult previously keyed decision off stage, so the ledger recorded deny instead of paused. Key the ternary off eventType instead. Closes JSONbored#8864
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-26 15:07:46 UTC
Review summary Nits — 3 non-blocking
CI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
denyResult's ledgerdecisionternary offeventType === kill_switchinstead ofstage === kill_switch, so budget-cap termination (stagebudget_cap, eventTypekill_switch) recordspausedlike the top-level kill-switch path.ledgerEvent.decision === paused, and add a vitest suite that covers the kill-switch / soft-deny / termination branches for codecov patch coverage.Closes #8864
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
packages/loopover-enginebuild +chokepoint.test.js(27 pass) andvitest run test/unit/engine-governor-chokepoint-kill-switch-decision.test.ts(3 pass). Unrelated UI/MCP/workers/actionlint checks not exercised.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — engine-only governor ledger decision fix; no visible UI.
Notes