fix(test,docs): resync installation-health fixtures and self-host docs with the #9169 required-events expansion - #9203
Merged
Conversation
…s with the #9169 required-events expansion #9169 promoted pull_request_review/check_run/check_suite to REQUIRED_INSTALLATION_EVENTS and switched the self-host setup wizard's manifest to derive default_events from that same canonical list. Three test fixtures (one in api.test.ts, two in backfill.test.ts) still mocked GitHub's live installation payload with the pre-#9169 event set, so their live-refresh assertions incorrectly expected a healthy status with no missing events. The self-hosting-github-app.mdx docs page's "Events: ..." sentence was similarly left describing the old 7-event list instead of the now- canonical 12-event set, failing the docs/manifest parity test. Also fixes an unrelated branding-drift regression surfaced by the same full test:ci run: a comment in predicted-gate-agreement.ts (added in #9173) still said "gittensory" instead of "loopover".
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
loopover-ui | d980434 | Commit Preview URL Branch Preview URL |
Jul 27 2026, 06:23 AM |
Bundle ReportChanges will increase total bundle size by 2.89kB (0.04%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: loopover-uiAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9203 +/- ##
=======================================
Coverage ? 93.56%
=======================================
Files ? 725
Lines ? 58867
Branches ? 20842
=======================================
Hits ? 55079
Misses ? 2881
Partials ? 907
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#9169promotedpull_request_review/check_run/check_suitetoREQUIRED_INSTALLATION_EVENTSand switched the self-host setup wizard's manifest to derivedefault_eventsfrom that same canonical list, but left three test fixtures and one docs page describing the pre-fix(webhook): catch a base retarget with no new commit, tighten event health, and stop label/issue churn from going stale #9169 event set.test/integration/api.test.tsandtest/unit/backfill.test.ts(2 spots) mocked GitHub's live installation payload with the old event list, so their live-refresh assertions incorrectly expected ahealthystatus with no missing events — this is what brokenpx vitest run test/integration/api.test.ts -t "serves installation repair diagnostics"onmain.apps/loopover-ui/content/docs/self-hosting-github-app.mdx's "Events: ..." sentence still listed the old 7-event set instead of the now-canonical 12-event set, failingsetup-wizard-docs-parity.test.ts.test:cirun: a comment insrc/review/predicted-gate-agreement.ts(added in#9173) still said "gittensory" instead of "loopover".Test plan
npx vitest run test/integration/api.test.ts test/unit/backfill.test.ts test/unit/setup-wizard-docs-parity.test.ts test/unit/check-branding-drift-script.test.ts— all greennpm run test:ci— full suite green (queue-4.test.ts's unrelated debounce regression, already fixed by orb(webhook): #9169's labeled/unlabeled public-surface trigger fires on ANY label, not just disposition labels — breaks the noisy-PR-event debounce #9175/fix(webhook): scope the label public-surface trigger to disposition labels only #9176, confirmed unaffected)npm audit --audit-level=moderate— only a pre-existing, unrelated transitive eslint/brace-expansion advisory, out of scope here