hotfix(manifest): restore the loopover-ui path rename and bundled-fallback sync lost in #9455's squash-merge - #9463
Merged
Conversation
…lback sync lost in #9455's squash-merge #9455 (screenshot-table gate re-enable) had two commits locally -- the initial add, and a follow-up fixup correcting the whenPaths prefix from the pre-rename apps/gittensory-ui to apps/loopover-ui, plus syncing src/config/loopover-repo-focus-manifest.ts (the bundled fallback) to match. The merged commit on main contains only the first: `.loopover.yml` still names apps/gittensory-ui (renamed away on 2026-07-14, so the gate has been enabled but silently INERT on every real PR -- the exact #9433 failure mode), and the bundled fallback has no screenshotTableGate block at all, which fails `npm run manifest:drift-check` -- a required, blocking step in test:ci -- for every PR against this repo until fixed. Restores both: corrects the path prefix, and re-adds the matching bundled-fallback block. Re-verified against the engine's own matchesAny matcher and a clean manifest-drift-check run.
9 tasks
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Contributor
|
Important 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏳ LoopOver is waiting…LoopOver has seen this pull request and is waiting on CI checks to finish before reviewing it. This comment will update once the review runs. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟨 Waiting |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9463 +/- ##
=======================================
Coverage ? 93.62%
=======================================
Files ? 741
Lines ? 60415
Branches ? 21296
=======================================
Hits ? 56564
Misses ? 2900
Partials ? 951
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
#9455 (re-enable the screenshot-table gate) had two commits on its branch: the initial add, and a follow-up fixup that (a) corrected
whenPathsfrom the pre-renameapps/gittensory-uitoapps/loopover-ui, and (b) syncedsrc/config/loopover-repo-focus-manifest.ts(the bundled fallback manifest) to match.loopover.yml, sincenpm run manifest:drift-checkrequires the two to agree.The merged commit on
maincontains only the first commit's content — both follow-up corrections were lost in the squash.Impact — this blocks CI repo-wide
.loopover.yml'sscreenshotTableGate.whenPathsstill namesapps/gittensory-ui/**, which was renamed away on 2026-07-14. The gate has been live but silently inert on every real PR since merging — ironically the exact "config-dependent fix ships inert" failure mode tracked in Config-dependent fixes can ship inert: audit env-gated behaviour for boot-time validation #9433.src/config/loopover-repo-focus-manifest.tshas noscreenshotTableGateblock at all, so it no longer matches.loopover.yml.npm run manifest:drift-check— a required step intest:ci— now fails on every PR against this repo, including the two I have open right now (fix(retention): dedupe contributor-decision-pack to latest-only, not a preserved series #9459, and this one's sibling investigation).Fix
Restores both corrections: the
apps/loopover-uipath prefix in.loopover.yml, and the matchingscreenshotTableGateblock in the bundled fallback.Verified:
npm run manifest:drift-checkpasses cleanmatchesAnynpm run typecheckcleanThis is a maintainer hotfix for a self-inflicted CI break, filed as its own PR since it's unrelated to my other open PR and needs to land first.