fix(signals): compare local branch repo names case-insensitively#965
Conversation
|
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Maintainer review — Ready to mergeReviewed 2 changed file(s) — two independent AI reviewers, synthesized. ✅ Safe to merge — both reviewers found no blocking issues. Summary The change correctly introduces case‑insensitive repository name comparison using the existing sameRepo helper, fixing a bug where contributor open‑PR counts were missed when repo name case differed. The added unit test validates the new behavior. No security concerns are introduced, and the modification improves maintainability. All existing tests continue to pass and the new test covers the edge case. 💡 Nits — non-blocking, optional
|
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #965 +/- ##
=======================================
Coverage 96.64% 96.64%
=======================================
Files 110 110
Lines 15033 15033
Branches 5432 5432
=======================================
Hits 14528 14528
Misses 104 104
Partials 401 401 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ghost
left a comment
There was a problem hiding this comment.
Recommend close (rejected) — held for your decision
ghost
left a comment
There was a problem hiding this comment.
Held for maintainer (guardrail_area) — correct + CI green
Motivation
repoFullNameuses different casing.Description
===repoFullName comparison with the existing case-insensitivesameRepo()helper insrc/signals/local-branch.tswhen computingcontributorOpenPrCount.test/unit/local-branch.test.tsthat exercises differently-casedrepoFullNameand contributorloginvalues to ensure same-repo open PRs are counted and pressure guidance recommends cleanup first.Testing
npm test -- --run test/unit/local-branch.test.ts, and all tests passed (44 passed).npm run typecheck(tsc --noEmit), which completed without errors.Codex Task